Skip to content
Permalink
Browse files
fix!: privatize deprecated constructor (#473)
* privatize deprecated method

* ignore removal of deprecated method

* api not locked down

* fix merge error

* move ignore file to submodule

Co-authored-by: Jeff Ching <chingor@google.com>
  • Loading branch information
elharo and chingor13 committed Dec 21, 2020
1 parent 269b49d commit 5804ff03a531268831ac797ab262638a3119c14f
Showing with 12 additions and 4 deletions.
  1. +11 −0 oauth2_http/clirr-ignored-differences.xml
  2. +1 −4 oauth2_http/java/com/google/auth/oauth2/ServiceAccountJwtAccessCredentials.java
@@ -0,0 +1,11 @@
<?xml version="1.0" encoding="UTF-8"?>
<!-- see https://www.mojohaus.org/clirr-maven-plugin/examples/ignored-differences.html -->
<differences>
<difference>
<differenceType>7009</differenceType>
<className>com/google/auth/oauth2/ServiceAccountJwtAccessCredentials</className>
<method>ServiceAccountJwtAccessCredentials(java.lang.String, java.lang.String, java.security.PrivateKey, java.lang.String)</method>
<from>public</from>
<to>private</to>
</difference>
</differences>
@@ -99,11 +99,8 @@ public class ServiceAccountJwtAccessCredentials extends Credentials
* @param clientEmail Client email address of the service account from the console.
* @param privateKey RSA private key object for the service account.
* @param privateKeyId Private key identifier for the service account. May be null.
* @deprecated Use {@link #newBuilder()} instead. This constructor will either be deleted or made
* private in a later version.
*/
@Deprecated
public ServiceAccountJwtAccessCredentials(
private ServiceAccountJwtAccessCredentials(
String clientId, String clientEmail, PrivateKey privateKey, String privateKeyId) {
this(clientId, clientEmail, privateKey, privateKeyId, null, null);
}

0 comments on commit 5804ff0

Please sign in to comment.