Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Automatic-Module-Name to manifest #324

Closed
elharo opened this issue Aug 9, 2019 · 2 comments
Closed

Add Automatic-Module-Name to manifest #324

elharo opened this issue Aug 9, 2019 · 2 comments
Assignees
Labels
good first issue help wanted semver: patch status: investigating

Comments

@elharo
Copy link
Contributor

@elharo elharo commented Aug 9, 2019

https://github.com/GoogleCloudPlatform/cloud-opensource-java/blob/master/library-best-practices/JLBP-20.md

@elharo elharo added good first issue help wanted semver: patch labels Aug 9, 2019
@elharo elharo added status: blocked good first issue help wanted status: investigating and removed good first issue help wanted status: blocked labels Aug 9, 2019
man0s added a commit to man0s/google-auth-library-java that referenced this issue Aug 9, 2019
man0s added a commit to man0s/google-auth-library-java that referenced this issue Aug 9, 2019
chingor13 pushed a commit that referenced this issue Aug 9, 2019
* fix: Automatic-Module-Name to manifest (#324)

* fix: Automatic-Module-Name to manifest (#324)

added changes

* fix: two space indents in /appengine/pom.xml

* fix: removed tabs
@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Aug 9, 2019

Fixed in #326

@elharo
Copy link
Contributor Author

@elharo elharo commented Aug 9, 2019

still need to add to google-auth-library-java/credentials/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted semver: patch status: investigating
Projects
None yet
Development

No branches or pull requests

2 participants