Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix declared dependencies from merge issue #291

Merged
merged 1 commit into from Jul 11, 2019
Merged

Fix declared dependencies from merge issue #291

merged 1 commit into from Jul 11, 2019

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jul 9, 2019

This direct dependency was added in #288, but the presubmit check was not yet set up. It was already being transitively pulled in via google-auth-library-oauth2-http

@chingor13 chingor13 requested a review from as a code owner Jul 9, 2019
@googlebot googlebot added the cla: yes label Jul 9, 2019
@codecov
Copy link

@codecov codecov bot commented Jul 9, 2019

Codecov Report

No coverage uploaded for pull request base (master@9b14268). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #291   +/-   ##
=========================================
  Coverage          ?   78.79%           
  Complexity        ?      340           
=========================================
  Files             ?       21           
  Lines             ?     1495           
  Branches          ?      162           
=========================================
  Hits              ?     1178           
  Misses            ?      238           
  Partials          ?       79

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b14268...6a02c42. Read the comment docs.

kolea2
kolea2 approved these changes Jul 11, 2019
@chingor13 chingor13 merged commit 35abf13 into googleapis:master Jul 11, 2019
9 checks passed
@chingor13 chingor13 deleted the fix-dep branch Jul 11, 2019
bcoe pushed a commit to bcoe/google-auth-library-java that referenced this issue Jul 26, 2019
@chingor13 chingor13 added the fix label Jul 26, 2019
bcoe pushed a commit to bcoe/google-auth-library-java that referenced this issue Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants