Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in ComputeEngineCredentials exception message #313

Merged
merged 3 commits into from Jul 31, 2019

Conversation

yebrahim
Copy link
Contributor

@yebrahim yebrahim commented Jul 30, 2019

No description provided.

@yebrahim yebrahim requested a review from as a code owner Jul 30, 2019
@googlebot googlebot added the cla: yes label Jul 30, 2019
elharo
elharo approved these changes Jul 30, 2019
Copy link
Contributor

@elharo elharo left a comment

The typo fix makes sense, though looking at this code now I strongly suspect this is not something we should be doing. That exception should not be wrapped and definitely not into a runtime exception.

@chingor13 chingor13 added the kokoro:force-run label Jul 30, 2019
@kokoro-team kokoro-team removed the kokoro:force-run label Jul 30, 2019
@chingor13 chingor13 changed the title Typo fix fix: typo in ComputeEngineCredentials exception message Jul 30, 2019
Copy link
Contributor

@chingor13 chingor13 left a comment

Thanks for submitting this!

Our test also appears to be validating the error message with the typo. Can you update the test cases as well?

@yebrahim
Copy link
Contributor Author

@yebrahim yebrahim commented Jul 31, 2019

Done.

@yebrahim yebrahim changed the title fix: typo in ComputeEngineCredentials exception message Fix typo in ComputeEngineCredentials exception message Jul 31, 2019
@chingor13 chingor13 added the kokoro:force-run label Jul 31, 2019
@kokoro-team kokoro-team removed the kokoro:force-run label Jul 31, 2019
Copy link
Contributor

@chingor13 chingor13 left a comment

Sorry, there's one more failed test

@yebrahim
Copy link
Contributor Author

@yebrahim yebrahim commented Jul 31, 2019

Done. Editing code on Github... :)

@chingor13 chingor13 added the kokoro:force-run label Jul 31, 2019
@kokoro-team kokoro-team removed the kokoro:force-run label Jul 31, 2019
@codecov
Copy link

@codecov codecov bot commented Jul 31, 2019

Codecov Report

Merging #313 into master will increase coverage by 0.55%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #313      +/-   ##
============================================
+ Coverage     78.42%   78.98%   +0.55%     
  Complexity      336      336              
============================================
  Files            22       22              
  Lines          1460     1513      +53     
  Branches        158      158              
============================================
+ Hits           1145     1195      +50     
- Misses          237      240       +3     
  Partials         78       78
Impacted Files Coverage Δ Complexity Δ
...m/google/auth/oauth2/ComputeEngineCredentials.java 83.89% <ø> (+1.99%) 25 <0> (ø) ⬇️
...uth/oauth2/ServiceAccountJwtAccessCredentials.java 73.75% <0%> (-0.88%) 36% <0%> (ø)
...google/auth/oauth2/DefaultCredentialsProvider.java 79.16% <0%> (-0.66%) 33% <0%> (ø)
...java/com/google/auth/oauth2/GoogleCredentials.java 57.89% <0%> (-0.44%) 8% <0%> (ø)
...p/java/com/google/auth/oauth2/UserCredentials.java 80.95% <0%> (-0.35%) 28% <0%> (ø)
...a/com/google/auth/oauth2/AppEngineCredentials.java 84.74% <0%> (-0.26%) 15% <0%> (ø)
.../google/auth/oauth2/ServiceAccountCredentials.java 84.21% <0%> (-0.03%) 44% <0%> (ø)
...va/com/google/auth/oauth2/MemoryTokensStorage.java 100% <0%> (ø) 4% <0%> (ø) ⬇️
...a/com/google/auth/http/HttpCredentialsAdapter.java 67.44% <0%> (ø) 8% <0%> (ø) ⬇️
credentials/java/com/google/auth/Credentials.java 0% <0%> (ø) 0% <0%> (ø) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2815eb9...3d6f119. Read the comment docs.

Copy link
Contributor

@chingor13 chingor13 left a comment

Thanks!

@chingor13 chingor13 merged commit 1a16f38 into googleapis:master Jul 31, 2019
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants