Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw SigningException as documented #316

Merged
merged 7 commits into from Jul 31, 2019
Merged

throw SigningException as documented #316

merged 7 commits into from Jul 31, 2019

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Jul 31, 2019

Least invasive change that partially addresses #314 but we need to change the API to correctly fix this. @chingor13

@elharo elharo requested a review from as a code owner Jul 31, 2019
@googlebot googlebot added the cla: yes label Jul 31, 2019
@codecov
Copy link

@codecov codecov bot commented Jul 31, 2019

Codecov Report

No coverage uploaded for pull request base (master@7fd94c0). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #316   +/-   ##
=========================================
  Coverage          ?   78.98%           
  Complexity        ?      336           
=========================================
  Files             ?       22           
  Lines             ?     1513           
  Branches          ?      158           
=========================================
  Hits              ?     1195           
  Misses            ?      240           
  Partials          ?       78
Impacted Files Coverage Δ Complexity Δ
...th2_http/java/com/google/auth/oauth2/IamUtils.java 97.61% <ø> (ø) 7 <0> (?)
...m/google/auth/oauth2/ComputeEngineCredentials.java 83.89% <100%> (ø) 25 <1> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd94c0...9760822. Read the comment docs.

@elharo elharo requested a review from chingor13 Jul 31, 2019
@chingor13 chingor13 merged commit a1ab97c into master Jul 31, 2019
10 checks passed
@chingor13 chingor13 deleted the ex branch Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants