feat: add Automatic-Module-Name to manifest (#324) #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
elharo
previously requested changes
Aug 9, 2019
- Each module needs a different name. You can only use com.google.auth for one.
- Two space indents, per Google style.
|
Thanks @elharo & @chingor13 for the suggestions. |
chingor13
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
chingor13
approved these changes
Aug 9, 2019
chingor13
changed the title
elharo
approved these changes
Aug 9, 2019
This looks good for these two. It's not a complete fix. We'll also need to do this for google-auth-library-java/credentials/ but we can commit this as is.
|
The credentials module was included. It's the |
|
My mistake. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
2/3 for #324
As stated in #325 by @elharo , Automatic-Module-Name need to be in submodules and not in parent.
lmk if everything is okay.