Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc #352

Merged
merged 1 commit into from Oct 2, 2019
Merged

Update doc #352

merged 1 commit into from Oct 2, 2019

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Oct 1, 2019

@chingor13 It's not immediately obvious to me why the autoupdate didn't catch this, but maybe there's a configuration issue somewhere?

Fixes #<issue_number_goes_here> (it's a good idea to open an issue first for context and/or discussion)

@suztomo It's not immediatley obvious to me why the autoupdate didn't catch this, but mayber there's a configuration issue somewhere?
@elharo elharo requested a review from as a code owner Oct 1, 2019
@googlebot googlebot added the cla: yes label Oct 1, 2019
@codecov
Copy link

@codecov codecov bot commented Oct 1, 2019

Codecov Report

Merging #352 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #352      +/-   ##
============================================
- Coverage     79.67%   79.63%   -0.04%     
  Complexity      389      389              
============================================
  Files            27       27              
  Lines          1761     1758       -3     
  Branches        183      181       -2     
============================================
- Hits           1403     1400       -3     
  Misses          262      262              
  Partials         96       96
Impacted Files Coverage Δ Complexity Δ
...om/google/auth/appengine/AppEngineCredentials.java 74.5% <0%> (-0.97%) 16% <0%> (ø)
...tp/java/com/google/auth/oauth2/UserAuthorizer.java 77.47% <0%> (-0.13%) 20% <0%> (ø)
...h2_http/java/com/google/auth/oauth2/JwtClaims.java 92.3% <0%> (ø) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ab8758...cc6a806. Read the comment docs.

@elharo elharo requested a review from chingor13 Oct 2, 2019
@chingor13 chingor13 merged commit f649735 into master Oct 2, 2019
9 of 11 checks passed
@chingor13 chingor13 deleted the elharo-patch-1 branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants