Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated comment on explicit IP address #370

Merged
merged 1 commit into from Oct 16, 2019
Merged

Remove outdated comment on explicit IP address #370

merged 1 commit into from Oct 16, 2019

Conversation

davidxia
Copy link
Contributor

@davidxia davidxia commented Oct 16, 2019

The explicit IP address is no longer used.

@davidxia davidxia requested a review from as a code owner Oct 16, 2019
@googlebot googlebot added the cla: yes label Oct 16, 2019
The explicit IP address is no longer used.
elharo
elharo approved these changes Oct 16, 2019
@chingor13 chingor13 added the kokoro:force-run label Oct 16, 2019
@kokoro-team kokoro-team removed the kokoro:force-run label Oct 16, 2019
@codecov
Copy link

@codecov codecov bot commented Oct 16, 2019

Codecov Report

Merging #370 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #370   +/-   ##
=========================================
  Coverage     79.67%   79.67%           
  Complexity      389      389           
=========================================
  Files            27       27           
  Lines          1761     1761           
  Branches        183      183           
=========================================
  Hits           1403     1403           
  Misses          262      262           
  Partials         96       96
Impacted Files Coverage Δ Complexity Δ
...m/google/auth/oauth2/ComputeEngineCredentials.java 83.45% <ø> (ø) 29 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42a1694...0b4ece9. Read the comment docs.

@chingor13 chingor13 merged commit 71faa5f into googleapis:master Oct 16, 2019
11 checks passed
@davidxia davidxia deleted the patch-1 branch Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants