Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bom/README.md #371

Closed
wants to merge 1 commit into from
Closed

Fix bom/README.md #371

wants to merge 1 commit into from

Conversation

kanterov
Copy link

@kanterov kanterov commented Oct 18, 2019

No description provided.

@kanterov kanterov requested a review from as a code owner Oct 18, 2019
@googlebot
Copy link

@googlebot googlebot commented Oct 18, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Oct 18, 2019
@kanterov
Copy link
Author

@kanterov kanterov commented Oct 18, 2019

@googlebot I signed it!

@BenWhitehead BenWhitehead added the kokoro:force-run label Oct 18, 2019
@kokoro-team kokoro-team removed the kokoro:force-run label Oct 18, 2019
@BenWhitehead
Copy link
Contributor

@BenWhitehead BenWhitehead commented Oct 18, 2019

@kanterov The email used for the commits in this PR (you're github no-reply email) isn't registered with your CLA signing. I'm going to ping a teammate offline to see what we can do here.

@codecov
Copy link

@codecov codecov bot commented Oct 18, 2019

Codecov Report

Merging #371 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #371   +/-   ##
=========================================
  Coverage     79.67%   79.67%           
  Complexity      389      389           
=========================================
  Files            27       27           
  Lines          1761     1761           
  Branches        183      183           
=========================================
  Hits           1403     1403           
  Misses          262      262           
  Partials         96       96
Impacted Files Coverage Δ Complexity Δ
...m/google/auth/oauth2/ComputeEngineCredentials.java 83.45% <0%> (ø) 29% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f02de9...fc58168. Read the comment docs.

@kanterov
Copy link
Author

@kanterov kanterov commented Oct 18, 2019

@googlebot I signed it!

@kanterov
Copy link
Author

@kanterov kanterov commented Oct 18, 2019

@BenWhitehead I fixed the email. As far as I know, my employer has signed CLA, but it didn't seem to work as well. I'm fine with closing this PR if you can do this 1 char change yourself because it doesn't seem to worth our time :)

BenWhitehead added a commit that referenced this issue Oct 18, 2019
@BenWhitehead
Copy link
Contributor

@BenWhitehead BenWhitehead commented Oct 18, 2019

Thanks for the contribution @kanterov and being flexible. I've opened #372 with the fix and passing cla check.

BenWhitehead added a commit that referenced this issue Oct 18, 2019
@kanterov kanterov deleted the patch-1 branch Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants