Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support reading in quotaProjectId for billing #383

Merged
merged 10 commits into from Dec 13, 2019

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Dec 9, 2019

No description provided.

@googlebot googlebot added the cla: yes label Dec 9, 2019
@codecov
Copy link

@codecov codecov bot commented Dec 9, 2019

Codecov Report

Merging #383 into master will decrease coverage by 0.1%.
The diff coverage is 78.84%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #383      +/-   ##
============================================
- Coverage     79.63%   79.53%   -0.11%     
- Complexity      389      397       +8     
============================================
  Files            27       27              
  Lines          1758     1803      +45     
  Branches        181      188       +7     
============================================
+ Hits           1400     1434      +34     
- Misses          262      269       +7     
- Partials         96      100       +4
Impacted Files Coverage Δ Complexity Δ
...p/java/com/google/auth/oauth2/UserCredentials.java 80% <75%> (-0.96%) 31 <2> (+3)
...uth/oauth2/ServiceAccountJwtAccessCredentials.java 75.32% <76.47%> (-0.2%) 38 <3> (+2)
...java/com/google/auth/oauth2/GoogleCredentials.java 61.36% <83.33%> (+3.46%) 10 <2> (+2) ⬆️
.../google/auth/oauth2/ServiceAccountCredentials.java 82.64% <84.61%> (-0.48%) 48 <5> (+1)
...tp/java/com/google/auth/oauth2/UserAuthorizer.java 77.59% <0%> (+0.12%) 20% <0%> (ø) ⬇️
...om/google/auth/appengine/AppEngineCredentials.java 75.47% <0%> (+0.96%) 16% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7267f3a...525beb8. Read the comment docs.

@codyoss codyoss marked this pull request as ready for review Dec 9, 2019
@codyoss codyoss requested a review from as a code owner Dec 9, 2019
@codyoss codyoss requested review from and removed request for Dec 9, 2019
@codyoss codyoss added the kokoro:force-run label Dec 11, 2019
@kokoro-team kokoro-team removed the kokoro:force-run label Dec 11, 2019
@codyoss codyoss requested a review from chingor13 Dec 11, 2019
@codyoss codyoss requested a review from chingor13 Dec 12, 2019
* @return New ServiceAccountJwtAcceessCredentials created from a private key.
* @throws IOException if the credential cannot be created from the private key.
*/
public static ServiceAccountJwtAccessCredentials fromPkcs8(
Copy link
Contributor

@chingor13 chingor13 Dec 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is also unnecessary

Copy link
Contributor

@chingor13 chingor13 Dec 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one actually needed?

Copy link
Member Author

@codyoss codyoss Dec 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say yes actually for this one. I moved it to package scope though as to not expose more surface to the api.

@codyoss codyoss merged commit f38c3c8 into googleapis:master Dec 13, 2019
10 of 12 checks passed
@codyoss codyoss deleted the quota-project branch Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants