Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add logging at FINE level for each step of ADC #435

Merged
merged 3 commits into from Aug 4, 2020

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented May 28, 2020

Fixes #430

Also changing the INFO message that we couldn't detect compute engine credentials as that's a perfectly normal case and can be checked by the return value.

@chingor13 chingor13 requested a review from as a code owner May 28, 2020
@googlebot googlebot added the cla: yes label May 28, 2020
@codecov
Copy link

@codecov codecov bot commented May 28, 2020

Codecov Report

Merging #435 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #435      +/-   ##
============================================
+ Coverage     79.50%   79.61%   +0.11%     
  Complexity      397      397              
============================================
  Files            27       27              
  Lines          1800     1810      +10     
  Branches        186      188       +2     
============================================
+ Hits           1431     1441      +10     
  Misses          269      269              
  Partials        100      100              
Impacted Files Coverage Δ Complexity Δ
...m/google/auth/oauth2/ComputeEngineCredentials.java 83.45% <100.00%> (ø) 29.00 <0.00> (ø)
...google/auth/oauth2/DefaultCredentialsProvider.java 80.31% <100.00%> (+1.14%) 33.00 <0.00> (ø)
...tp/java/com/google/auth/oauth2/UserAuthorizer.java 77.59% <0.00%> (+0.12%) 20.00% <0.00%> (ø%)
...om/google/auth/appengine/AppEngineCredentials.java 75.47% <0.00%> (+0.96%) 16.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 662bd80...fc7b3b4. Read the comment docs.

elharo
elharo approved these changes Aug 4, 2020
@chingor13 chingor13 merged commit 7d145b2 into googleapis:master Aug 4, 2020
11 checks passed
@chingor13 chingor13 deleted the adc-logging branch Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants