Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: privatize deprecated constructor #473

Merged
merged 7 commits into from Dec 21, 2020
Merged

fix!: privatize deprecated constructor #473

merged 7 commits into from Dec 21, 2020

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Aug 31, 2020

@kolea2 one of last two deprecated methods to clean up before releasing 1.0

see #238

Can we take care of this now? I think https://www.github.com/googleapis/google-auth-library-java/issues/350 means we can do this now.

@elharo elharo requested a review from chingor13 Aug 31, 2020
@elharo elharo requested a review from as a code owner Aug 31, 2020
@google-cla google-cla bot added the cla: yes label Aug 31, 2020
@elharo elharo requested review from kolea2 and removed request for chingor13 Aug 31, 2020
@elharo
Copy link
Contributor Author

@elharo elharo commented Aug 31, 2020

[ERROR] 7009: com.google.auth.oauth2.ServiceAccountJwtAccessCredentials: Accessibility of method 'public ServiceAccountJwtAccessCredentials(java.lang.String, java.lang.String, java.security.PrivateKey, java.lang.String)' has been decreased from public to private

is expected and this library is pre-1.0

@elharo elharo changed the title privatize deprecated method privatize deprecated constructor Aug 31, 2020
clirr-ignored-differences.xml Outdated Show resolved Hide resolved
pom.xml Outdated Show resolved Hide resolved
@elharo elharo changed the title privatize deprecated constructor fix!: privatize deprecated constructor Sep 18, 2020
@codecov
Copy link

@codecov codecov bot commented Dec 16, 2020

Codecov Report

Merging #473 (40af346) into master (269b49d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #473   +/-   ##
=========================================
  Coverage     79.98%   79.98%           
  Complexity      420      420           
=========================================
  Files            28       28           
  Lines          1964     1964           
  Branches        208      208           
=========================================
  Hits           1571     1571           
  Misses          284      284           
  Partials        109      109           
Impacted Files Coverage Δ Complexity Δ
...uth/oauth2/ServiceAccountJwtAccessCredentials.java 75.64% <ø> (ø) 40.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 269b49d...40af346. Read the comment docs.

@elharo elharo merged commit 5804ff0 into master Dec 21, 2020
15 checks passed
@elharo elharo deleted the ae branch Dec 21, 2020
@release-please release-please bot mentioned this pull request Dec 29, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 26, 2021
🤖 I have created a release \*beep\* \*boop\* 
---
## [0.23.0](https://www.github.com/googleapis/google-auth-library-java/compare/v0.22.2...v0.23.0) (2021-01-26)


###  BREAKING CHANGES

* privatize deprecated constructor (#473)

### Features

* allow custom lifespan for impersonated creds ([#515](https://www.github.com/googleapis/google-auth-library-java/issues/515)) ([0707ed4](https://www.github.com/googleapis/google-auth-library-java/commit/0707ed4bbb40fb775f196004ee30f8c695fe662b))
* allow custom scopes for compute engine creds ([#514](https://www.github.com/googleapis/google-auth-library-java/issues/514)) ([edc8d6e](https://www.github.com/googleapis/google-auth-library-java/commit/edc8d6e0e7ca2c6749d026ba42854a09c4879fd6))
* allow set lifetime for service account creds ([#516](https://www.github.com/googleapis/google-auth-library-java/issues/516)) ([427f2d5](https://www.github.com/googleapis/google-auth-library-java/commit/427f2d5610f0e8184a21b24531d2549a68c0b546))
* promote IdToken and JWT features ([#538](https://www.github.com/googleapis/google-auth-library-java/issues/538)) ([b514fe0](https://www.github.com/googleapis/google-auth-library-java/commit/b514fe0cebe5a294e0cf97b7b5349e6a523dc7b2))


### Bug Fixes

* per google style, logger is lower case ([#529](https://www.github.com/googleapis/google-auth-library-java/issues/529)) ([ecfc6a2](https://www.github.com/googleapis/google-auth-library-java/commit/ecfc6a2ea6060e06629b5d422b23b842b917f55e))
* privatize deprecated constructor ([#473](https://www.github.com/googleapis/google-auth-library-java/issues/473)) ([5804ff0](https://www.github.com/googleapis/google-auth-library-java/commit/5804ff03a531268831ac797ab262638a3119c14f))
* remove deprecated methods ([#537](https://www.github.com/googleapis/google-auth-library-java/issues/537)) ([427963e](https://www.github.com/googleapis/google-auth-library-java/commit/427963e04702d8b73eca5ed555539b11bbe97342))
* replace non-precondition use of Preconditions ([#539](https://www.github.com/googleapis/google-auth-library-java/issues/539)) ([f2ab4f1](https://www.github.com/googleapis/google-auth-library-java/commit/f2ab4f14262d54de0fde85494cfd92cf01a30cbe))
* switch to GSON ([#531](https://www.github.com/googleapis/google-auth-library-java/issues/531)) ([1b98d5c](https://www.github.com/googleapis/google-auth-library-java/commit/1b98d5c86fc5e56187c977e7f43c39bb62483d40))
* use default timeout if given 0 for ImpersonatedCredentials ([#527](https://www.github.com/googleapis/google-auth-library-java/issues/527)) ([ec74870](https://www.github.com/googleapis/google-auth-library-java/commit/ec74870c372a33d4157b45bb5d59ad7464fb2238))


### Dependencies

* update dependency com.google.appengine:appengine-api-1.0-sdk to v1.9.84 ([#422](https://www.github.com/googleapis/google-auth-library-java/issues/422)) ([b262c45](https://www.github.com/googleapis/google-auth-library-java/commit/b262c4587b058e6837429ee05f1b6a63620ee598))
* update dependency com.google.guava:guava to v30.1-android ([#522](https://www.github.com/googleapis/google-auth-library-java/issues/522)) ([4090d1c](https://www.github.com/googleapis/google-auth-library-java/commit/4090d1cb50041bceb1cd975d1a9249a412df936f))


### Documentation

* fix wording in jwtWithClaims Javadoc ([#536](https://www.github.com/googleapis/google-auth-library-java/issues/536)) ([af21727](https://www.github.com/googleapis/google-auth-library-java/commit/af21727815263fb5ffc07ede953cf042fac3ac2b))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants