Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove 1 hour limit for the impersonated token #490

Merged
merged 1 commit into from Oct 15, 2020

Conversation

shinfan
Copy link
Contributor

@shinfan shinfan commented Oct 15, 2020

Cloud IAM now supports extended 12h lifespan for access token:
https://cloud.google.com/iam/docs/creating-short-lived-service-account-credentials#sa-credentials-oauth

A separate PR should be made to allow developers to specify the desired lifespan of the granted token.

@shinfan shinfan requested a review from as a code owner Oct 15, 2020
@google-cla google-cla bot added the cla: yes label Oct 15, 2020
@haogang
Copy link

@haogang haogang commented Oct 15, 2020

Thanks @shinfan. Do we know which SDK release will include this change, and when will it be released to the maven repo?

elharo
elharo previously requested changes Oct 15, 2020
Copy link
Contributor

@elharo elharo left a comment

tests are failing

Cloud IAM now supports extended 12h lifespan for access token.
@chingor13 chingor13 changed the title Remove 1 hour limit for the impersonated token fix: remove 1 hour limit for the impersonated token Oct 15, 2020
@chingor13 chingor13 added the automerge label Oct 15, 2020
@chingor13 chingor13 merged commit 927e3d5 into googleapis:master Oct 15, 2020
10 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Oct 15, 2020
@shinfan
Copy link
Contributor Author

@shinfan shinfan commented Oct 16, 2020

Do we need to cut a release for this fix? @chingor13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants