Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: per google style, logger is lower case #529

Merged
merged 3 commits into from Dec 31, 2020
Merged

fix: per google style, logger is lower case #529

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62baddb
per google style, logger is lower case
Dec 21, 2020
45e5b25
format
Dec 21, 2020
c7565c7
Merge branch 'master' into ae
elharo Dec 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 9 additions & 7 deletions appengine/java/com/google/auth/appengine/AppEngineCredentials.java
View file
Open in desktop
Expand Up @@ -56,11 +56,7 @@
*/
public class AppEngineCredentials extends GoogleCredentials implements ServiceAccountSigner {

private static final Logger LOGGER = Logger.getLogger(AppEngineCredentials.class.getName());
private static final String APPLICATION_DEFAULT_CREDENTIALS_WARNING =
"You are attempting to "
+ "fetch Application Default Credentials from com.google.auth.appengine.AppEngineCredentials."
+ " This method will not return a com.google.auth.appengine.AppEngineCredentials instance.";
private static final Logger logger = Logger.getLogger(AppEngineCredentials.class.getName());
private static final long serialVersionUID = -2627708355455064660L;

private final String appIdentityServiceClassName;
Expand All @@ -75,7 +71,10 @@ public class AppEngineCredentials extends GoogleCredentials implements ServiceAc
*/
@Deprecated
public static GoogleCredentials getApplicationDefault() throws IOException {
LOGGER.warning(APPLICATION_DEFAULT_CREDENTIALS_WARNING);
logger.warning(
"You are attempting to "
+ "fetch Application Default Credentials from com.google.auth.appengine.AppEngineCredentials."
+ " This method will not return a com.google.auth.appengine.AppEngineCredentials instance.");
return GoogleCredentials.getApplicationDefault();
}

Expand All @@ -86,7 +85,10 @@ public static GoogleCredentials getApplicationDefault() throws IOException {
@Deprecated
public static GoogleCredentials getApplicationDefault(HttpTransportFactory transportFactory)
throws IOException {
LOGGER.warning(APPLICATION_DEFAULT_CREDENTIALS_WARNING);
logger.warning(
"You are attempting to fetch "
+ "Application Default Credentials from com.google.auth.appengine.AppEngineCredentials. "
+ "This method does not return a com.google.auth.appengine.AppEngineCredentials instance.");
return GoogleCredentials.getApplicationDefault(transportFactory);
}

Expand Down