Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove deprecated methods #537

merged 5 commits into from Jan 14, 2021

fix: remove deprecated methods #537

merged 5 commits into from Jan 14, 2021


Copy link

@elharo elharo commented Jan 12, 2021

This library is pre-1.0. If any dependencies need this, we should find out now so we can undeprecate these methods.

@elharo elharo requested a review from chingor13 Jan 12, 2021
@elharo elharo requested a review from as a code owner Jan 12, 2021
@google-cla google-cla bot added the cla: yes label Jan 12, 2021
Copy link

@codecov codecov bot commented Jan 12, 2021

Codecov Report

Merging #537 (9f111fc) into master (f2ab4f1) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #537      +/-   ##
+ Coverage     79.87%   79.92%   +0.05%     
+ Complexity      424      421       -3     
  Files            28       28              
  Lines          1983     1978       -5     
  Branches        215      215              
- Hits           1584     1581       -3     
+ Misses          286      284       -2     
  Partials        113      113              
Impacted Files Coverage Δ Complexity Δ 72.91% <ø> (+1.21%) 13.00 <0.00> (-3.00) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2ab4f1...9f111fc. Read the comment docs.

Copy link

@chingor13 chingor13 commented Jan 12, 2021

For context, I added these overrides because users were confused calling the static getApplicationDefault() on the AppEngineCredentials class. AppEngineCredentials didn't provide this method (it would fall back to use the superclass GoogleCredentials' implementaiton) so we added this deprecation warning to keep folks from using this as it will never return an instance of AppEngineCredentials.

Copy link

@chingor13 chingor13 left a comment

Need to remove the direct dependency declaration on google-http-client for the appengine artifact.

@chingor13 chingor13 changed the title remove deprecated methods fix: remove deprecated methods Jan 14, 2021
@elharo elharo merged commit 427963e into master Jan 14, 2021
14 checks passed
@elharo elharo deleted the depre branch Jan 14, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Jan 26, 2021
🤖 I have created a release \*beep\* \*boop\* 
## [0.23.0]( (2021-01-26)


* privatize deprecated constructor (#473)

### Features

* allow custom lifespan for impersonated creds ([#515]( ([0707ed4](
* allow custom scopes for compute engine creds ([#514]( ([edc8d6e](
* allow set lifetime for service account creds ([#516]( ([427f2d5](
* promote IdToken and JWT features ([#538]( ([b514fe0](

### Bug Fixes

* per google style, logger is lower case ([#529]( ([ecfc6a2](
* privatize deprecated constructor ([#473]( ([5804ff0](
* remove deprecated methods ([#537]( ([427963e](
* replace non-precondition use of Preconditions ([#539]( ([f2ab4f1](
* switch to GSON ([#531]( ([1b98d5c](
* use default timeout if given 0 for ImpersonatedCredentials ([#527]( ([ec74870](

### Dependencies

* update dependency to v1.9.84 ([#422]( ([b262c45](
* update dependency to v30.1-android ([#522]( ([4090d1c](

### Documentation

* fix wording in jwtWithClaims Javadoc ([#536]( ([af21727](

This PR was generated with [Release Please]( See [documentation](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
cla: yes
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants