Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support AWS_DEFAULT_REGION env var #599

Merged
merged 2 commits into from Mar 18, 2021

Conversation

lsirac
Copy link
Collaborator

@lsirac lsirac commented Mar 17, 2021

AWS_DEFAULT_REGION env var should be checked after AWS_REGION. See b/182491887.

@lsirac lsirac requested a review from as a code owner Mar 17, 2021
@google-cla google-cla bot added the cla: yes label Mar 17, 2021
@codecov
Copy link

@codecov codecov bot commented Mar 17, 2021

Codecov Report

Merging #599 (5b1864e) into master (bf3507c) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #599      +/-   ##
============================================
+ Coverage     83.49%   83.59%   +0.09%     
- Complexity      600      602       +2     
============================================
  Files            42       42              
  Lines          2709     2712       +3     
  Branches        288      289       +1     
============================================
+ Hits           2262     2267       +5     
+ Misses          304      303       -1     
+ Partials        143      142       -1     
Impacted Files Coverage Δ Complexity Δ
...tp/java/com/google/auth/oauth2/AwsCredentials.java 95.32% <100.00%> (+2.05%) 17.00 <0.00> (+2.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf3507c...5b1864e. Read the comment docs.

@lsirac lsirac requested a review from chingor13 Mar 17, 2021
@chingor13 chingor13 changed the title feat: support AWS_DEFAULT_REGION env var fix: support AWS_DEFAULT_REGION env var Mar 18, 2021
@chingor13 chingor13 added the automerge label Mar 18, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3d066ee into googleapis:master Mar 18, 2021
25 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge label Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants