Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix service account credentials createScopedRequired #601

Merged
merged 2 commits into from Mar 18, 2021
Merged

Conversation

arithmetic1728
Copy link
Collaborator

@arithmetic1728 arithmetic1728 commented Mar 18, 2021

@google-cla google-cla bot added the cla: yes label Mar 18, 2021
@codecov
Copy link

@codecov codecov bot commented Mar 18, 2021

Codecov Report

Merging #601 (8a23d96) into master (31ebe6e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #601   +/-   ##
=========================================
  Coverage     83.49%   83.49%           
- Complexity      599      600    +1     
=========================================
  Files            42       42           
  Lines          2708     2709    +1     
  Branches        288      288           
=========================================
+ Hits           2261     2262    +1     
  Misses          304      304           
  Partials        143      143           
Impacted Files Coverage Δ Complexity Δ
.../google/auth/oauth2/ServiceAccountCredentials.java 83.50% <100.00%> (+0.05%) 65.00 <1.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31ebe6e...8a23d96. Read the comment docs.

@arithmetic1728 arithmetic1728 marked this pull request as ready for review Mar 18, 2021
@arithmetic1728 arithmetic1728 requested a review from as a code owner Mar 18, 2021
@arithmetic1728 arithmetic1728 requested a review from bshaffer Mar 18, 2021
lesv
lesv approved these changes Mar 18, 2021
@arithmetic1728 arithmetic1728 merged commit 0614482 into master Mar 18, 2021
15 checks passed
@arithmetic1728 arithmetic1728 deleted the jwt_fix branch Mar 18, 2021
/** Returns whether the scopes are empty, meaning createScoped must be called before use. */
@Override
public boolean createScopedRequired() {
return scopes.isEmpty();
Copy link
Contributor

@bshaffer bshaffer Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think without having defaultScopes.isEmpty() here as well, the Client Library for Storage will never use self-signed JWTs. And there may be more APIs like this.

This can be fixed in a future PR, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants