Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Returning an issuer claim on request errors #656

Merged
merged 9 commits into from May 17, 2021
Merged

Conversation

TimurSadykov
Copy link
Member

@TimurSadykov TimurSadykov commented May 10, 2021

Adding additional data to debug issues, where token request intermittently returns invalid_grant errors.

This does not fix the #654 completely, but a step forward.

Fixes #654 ☕️

@TimurSadykov TimurSadykov requested a review from as a code owner May 10, 2021
@google-cla
Copy link

@google-cla google-cla bot commented May 10, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 10, 2021
@TimurSadykov TimurSadykov changed the title Returning an issuer claim on request errors feat: Returning an issuer claim on request errors May 10, 2021
@TimurSadykov TimurSadykov requested a review from silvolu May 10, 2021
@codecov
Copy link

@codecov codecov bot commented May 10, 2021

Codecov Report

Merging #656 (26a1fcb) into master (292e81a) will decrease coverage by 0.10%.
The diff coverage is 58.33%.

Current head 26a1fcb differs from pull request most recent head 16d34c3. Consider uploading reports for the commit 16d34c3 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #656      +/-   ##
============================================
- Coverage     83.59%   83.48%   -0.11%     
- Complexity      606      607       +1     
============================================
  Files            42       42              
  Lines          2712     2719       +7     
  Branches        289      289              
============================================
+ Hits           2267     2270       +3     
- Misses          303      307       +4     
  Partials        142      142              
Impacted Files Coverage Δ Complexity Δ
.../google/auth/oauth2/ServiceAccountCredentials.java 82.55% <58.33%> (-0.96%) 68.00 <1.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9633e45...16d34c3. Read the comment docs.

@googlebot
Copy link

@googlebot googlebot commented May 10, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

@googlebot googlebot commented May 10, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

@googlebot googlebot commented May 10, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels May 10, 2021
@TimurSadykov TimurSadykov merged commit 95d70ae into master May 17, 2021
13 checks passed
@TimurSadykov TimurSadykov deleted the stim-errorlogs branch May 17, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue May 20, 2021
🤖 I have created a release \*beep\* \*boop\*
---
## [0.26.0](https://www.github.com/googleapis/google-auth-library-java/compare/v0.25.5...v0.26.0) (2021-05-20)


### Features

* add `gcf-owl-bot[bot]` to `ignoreAuthors` ([#674](https://www.github.com/googleapis/google-auth-library-java/issues/674)) ([359b20f](https://www.github.com/googleapis/google-auth-library-java/commit/359b20f24f88e09b6b104c61ca63a1b604ea64d2))
* added getter for credentials object in HttpCredentialsAdapter ([#658](https://www.github.com/googleapis/google-auth-library-java/issues/658)) ([5a946ea](https://www.github.com/googleapis/google-auth-library-java/commit/5a946ea5e0d974611f2205f468236db4b931e486))
* enable pre-emptive async oauth token refreshes ([#646](https://www.github.com/googleapis/google-auth-library-java/issues/646)) ([e3f4c7e](https://www.github.com/googleapis/google-auth-library-java/commit/e3f4c7eac0417705553ef8259599ec29fc8ad9b4))
* Returning an issuer claim on request errors ([#656](https://www.github.com/googleapis/google-auth-library-java/issues/656)) ([95d70ae](https://www.github.com/googleapis/google-auth-library-java/commit/95d70ae0f5f4c985455f913ddef14ebe75500656))


### Bug Fixes

* use orginal url as audience for self signed jwt if scheme or host is null ([#642](https://www.github.com/googleapis/google-auth-library-java/issues/642)) ([b4e6f1a](https://www.github.com/googleapis/google-auth-library-java/commit/b4e6f1a0bd17dd31edc85ed4879cea75857fd747))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants