Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add validation for the token URL and service account impersonation URL for Workload Identity Federation #717

Merged
merged 4 commits into from Aug 17, 2021

Conversation

lsirac
Copy link
Collaborator

@lsirac lsirac commented Aug 11, 2021

Matches the token URLs host to:

  • *.sts.googleapis.com
  • sts.googleapis.com
  • sts.*.googleapis.com
  • *-sts.googleapis.com

Matches the service account impersonation URLs host to:

  • *.iamcredentials.googleapis.com
  • iamcredentials.googleapis.com
  • iamcredentials.*.googleapis.com
  • *-iamcredentials.googleapis.com

Scheme must be HTTPS.

@lsirac lsirac requested a review from as a code owner Aug 11, 2021
@google-cla google-cla bot added the cla: yes label Aug 11, 2021
@lsirac lsirac requested a review from TimurSadykov Aug 11, 2021
Copy link
Member

@TimurSadykov TimurSadykov left a comment

LGTM, some minor suggestions on test cases

@lsirac lsirac requested a review from Neenu1995 Aug 12, 2021
@lsirac lsirac requested a review from lesv Aug 12, 2021
@lsirac lsirac merged commit 23cb8ef into googleapis:master Aug 17, 2021
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants