Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Workforce Pools #729

Merged
merged 7 commits into from Sep 21, 2021
Merged

feat: add support for Workforce Pools #729

merged 7 commits into from Sep 21, 2021

Conversation

lsirac
Copy link
Collaborator

@lsirac lsirac commented Sep 7, 2021

See go/workforce-pools-client-support.

@lsirac lsirac requested a review from as a code owner Sep 7, 2021
@google-cla google-cla bot added the cla: yes label Sep 7, 2021
@lsirac lsirac requested a review from TimurSadykov Sep 7, 2021
@lsirac lsirac force-pushed the wf branch 2 times, most recently from 7c989b2 to b3fdaec Compare Sep 9, 2021
@TimurSadykov
Copy link
Member

@TimurSadykov TimurSadykov commented Sep 13, 2021

@lsirac unrelated to this feature, but I see there is a transportFactoryClassName that is never used. Is it expected?

@lsirac lsirac requested a review from TimurSadykov Sep 21, 2021
Copy link
Member

@TimurSadykov TimurSadykov left a comment

LGTM

Copy link
Contributor

@chingor13 chingor13 left a comment

Just a question on whether we need to expose those workforce pool methods?

@lsirac lsirac merged commit 5f3fed7 into googleapis:master Sep 21, 2021
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants