[DO NOT MERGE]: feat(crypto): play with webcrypto API #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
| return crypto.randomBytes(count).toString('base64'); | ||
| const array = new Uint8Array(count); | ||
| webcrypto.getRandomValues(array); | ||
| return base64js.fromByteArray(array); |
There was a problem hiding this comment.
Since we're in Node context, we still can use Buffer.from here, right?
There was a problem hiding this comment.
In playing I couldn't seem to, seems like this might be a good improvement.
| @@ -14,32 +14,100 @@ | |||
|
|
|||
| import * as crypto from 'crypto'; | |||
| import {Crypto} from '../crypto'; | |||
| import * as base64js from 'base64-js'; | |||
There was a problem hiding this comment.
So this is cool and all, but the real test would be to delete this file, and rely on the browser context one we've already written :) That is already using SubtleCrypto, so if node is API compatible it should slide right in. This PR could just be a deleted file!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
play with web-crypto API, so that we can provide feedback to Node.js project.