Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(GCS+gRPC): remove unused functions #7038

Merged

Conversation

coryan
Copy link
Member

@coryan coryan commented Jul 21, 2021

Remove functions mapping between REST and gRPC requess, responses, and
metadata. These were only used in tests after the last cleanup.

Part of the work for #6982


This change is Reviewable

Remove functions mapping between REST and gRPC requess, responses, and
metadata. These were only used in tests after the last cleanup.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 21, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 4250a0e1d92e7bcb681f035ac8b3f586dfb4f4a5

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #7038 (8ef4f75) into main (46c9e78) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             main    #7038     +/-   ##
=========================================
  Coverage   94.47%   94.47%             
=========================================
  Files        1306     1304      -2     
  Lines      113551   112300   -1251     
=========================================
- Hits       107281   106100   -1181     
+ Misses       6270     6200     -70     
Impacted Files Coverage Δ
google/cloud/storage/internal/grpc_client.cc 92.39% <ø> (+2.35%) ⬆️
google/cloud/storage/internal/grpc_client.h 100.00% <ø> (ø)
...torage/internal/grpc_client_object_request_test.cc 100.00% <ø> (ø)
google/cloud/storage/internal/grpc_client_test.cc 100.00% <ø> (ø)
google/cloud/bigtable/async_read_stream_test.cc 97.32% <0.00%> (-0.67%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 97.00% <0.00%> (-0.60%) ⬇️
google/cloud/storage/notification_metadata.h 98.14% <0.00%> (-0.07%) ⬇️
google/cloud/storage/internal/bucket_requests.h 100.00% <0.00%> (ø)
...gle/cloud/storage/internal/notification_requests.h 100.00% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46c9e78...8ef4f75. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 452cd4d28db19a7c9f81be93efa11c4e0456c7b6

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review July 21, 2021 20:38
@coryan coryan requested a review from a team as a code owner July 21, 2021 20:38
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 8ef4f752eb334a1af215ebf155326a50750a8bf9

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan merged commit 30907bc into googleapis:main Jul 21, 2021
@coryan coryan deleted the cleanup-storage-remove-unused-gcs-grpc-functions branch July 21, 2021 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants