Skip to content

Commit

Permalink
feat(cloudbuild): Start generating apiv1/v3 (#2830)
Browse files Browse the repository at this point in the history
A recent [change](googleapis/googleapis@48ce887) has removed some apis from the surface of
apiv1/v2. As this is a breaking change, we need to start generating
sources under a new import path. A future commit will deprecated
the previous package.
  • Loading branch information
codyoss authored Sep 9, 2020
1 parent 2b0a5d9 commit 358a536
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion internal/gapicgen/generator/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -545,7 +545,7 @@ var microgenGapicConfigs = []*microgenConfig{
{
inputDirectoryPath: "google/devtools/cloudbuild/v1",
pkg: "cloudbuild",
importPath: "cloud.google.com/go/cloudbuild/apiv1/v2",
importPath: "cloud.google.com/go/cloudbuild/apiv1/v3",
gRPCServiceConfigPath: "google/devtools/cloudbuild/v1/cloudbuild_grpc_service_config.json",
apiServiceConfigPath: "google/devtools/cloudbuild/v1/cloudbuild_v1.yaml",
releaseLevel: "ga",
Expand Down
1 change: 1 addition & 0 deletions internal/gapicgen/generator/config_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ var apivExceptions = map[string]bool{
"cloud.google.com/go/firestore/apiv1/admin": true,
"cloud.google.com/go/cloudbuild/apiv1/v2": true,
"cloud.google.com/go/monitoring/apiv3/v2": true,
"cloud.google.com/go/cloudbuild/apiv1/v3": true,
}

// TestMicrogenConfigs validates config entries.
Expand Down

0 comments on commit 358a536

Please sign in to comment.