fix(bigquery/storage/managedwriter): fix flowcontroller double-release (#4555)

shollyman · web-flow · commit 67facd9697e9 · 2021-08-05T16:56:32.000Z
Stress testing caught this one: responsibility for releasing flow controlled resources is in markDone of pending write, and the reference in the recvProcessor was over-freeing resources. Towards: #4366
diff --git a/bigquery/storage/managedwriter/managed_stream.go b/bigquery/storage/managedwriter/managed_stream.go
@@ -358,7 +358,6 @@ func recvProcessor(ctx context.Context, arc storagepb.BigQueryWrite_AppendRowsCl
 			recordStat(ctx, AppendResponses, 1)
 
 			if status := resp.GetError(); status != nil {
-				fc.release(nextWrite.reqSize)
 				nextWrite.markDone(NoStreamOffset, grpcstatus.ErrorProto(status), fc)
 				continue
 			}

Original file line number	Diff line number	Diff line change
`@@ -358,7 +358,6 @@ func recvProcessor(ctx context.Context, arc storagepb.BigQueryWrite_AppendRowsCl`
`358`	`358`	`recordStat(ctx, AppendResponses, 1)`
`359`	`359`
`360`	`360`	`if status := resp.GetError(); status != nil {`
`361`		`- fc.release(nextWrite.reqSize)`
`362`	`361`	`nextWrite.markDone(NoStreamOffset, grpcstatus.ErrorProto(status), fc)`
`363`	`362`	`continue`
`364`	`363`	`}`