feat(spannertest): Add validation of duplicated column names (#4611)

sryoya · olavloite · web-flow · commit 84f86a605c80 · 2021-08-16T11:59:00.000+02:00
* feat(spannertest): add validation for duplicated column names

* feat(spannertest): fix error message in validation of duplicated column

Co-authored-by: Knut Olav Løite &lt;koloite@gmail.com&gt;

Co-authored-by: Knut Olav Løite &lt;koloite@gmail.com&gt;
diff --git a/spanner/spannertest/db.go b/spanner/spannertest/db.go
@@ -622,6 +622,10 @@ func (t *table) addColumn(cd spansql.ColumnDef, newTable bool) *status.Status {
 		return status.Newf(codes.InvalidArgument, "new non-key columns cannot be NOT NULL")
 	}
 
+	if _, ok := t.colIndex[cd.Name]; ok {
+		return status.Newf(codes.AlreadyExists, "column %s already exists", cd.Name)
+	}
+
 	t.mu.Lock()
 	defer t.mu.Unlock()
 

Original file line number	Diff line number	Diff line change
`@@ -622,6 +622,10 @@ func (t table) addColumn(cd spansql.ColumnDef, newTable bool) status.Status {`
`622`	`622`	`return status.Newf(codes.InvalidArgument, "new non-key columns cannot be NOT NULL")`
`623`	`623`	`}`
`624`	`624`
	`625`	`+ if _, ok := t.colIndex[cd.Name]; ok {`
	`626`	`+ return status.Newf(codes.AlreadyExists, "column %s already exists", cd.Name)`
	`627`	`+ }`
	`628`	`+`
`625`	`629`	`t.mu.Lock()`
`626`	`630`	`defer t.mu.Unlock()`
`627`	`631`