Skip to content

Commit 98779eb

Browse files
authored
fix(bigquery): address one other callsite for the job construction feature (#5059)
As part of the changes for #5048 one callsite of getJobInternal was missed. Normally this would easily get identified due to the change in signature, but getJobInternal has a set of expected string arguments, followed by variadic string args. This got picked up by integration testing, but I failed to recall that presubmit doesn't run integration tests so it was caught after submit. Mostly this one's a cautionary tale for having a mix of mandatory and variadic functions that share the same type. Fixes: #5058
1 parent 1b81e60 commit 98779eb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Diff for: bigquery/job.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ func (j *Job) Status(ctx context.Context) (js *JobStatus, err error) {
207207
ctx = trace.StartSpan(ctx, "cloud.google.com/go/bigquery.Job.Status")
208208
defer func() { trace.EndSpan(ctx, err) }()
209209

210-
bqjob, err := j.c.getJobInternal(ctx, j.jobID, j.location, "status", "statistics")
210+
bqjob, err := j.c.getJobInternal(ctx, j.jobID, j.location, j.projectID, "status", "statistics")
211211
if err != nil {
212212
return nil, err
213213
}

0 commit comments

Comments
 (0)