fix(internal/godocfx): set exit code, print cmd output, no go get ... (#4445)

Author: tbpg

internal/godocfx/main.go

@@ -113,22 +113,30 @@ func main() {
 	}
 	// Use a fake module that doesn't start with cloud.google.com/go.
 	runCmd(workingDir, "go", "mod", "init", "cloud.google.com/lets-build-some-docs")
+
+	failed := false
 	for _, m := range mods {
 		log.Printf("Processing %s@%s", m.Path, m.Version)
 
 		// Always output to specific directory.
 		path := filepath.Join(*outDir, fmt.Sprintf("%s@%s", m.Path, m.Version))
 		if err := process(m, workingDir, path, *print); err != nil {
 			log.Printf("Failed to process %v: %v", m, err)
+			failed = true
 		}
 		log.Printf("Done with %s@%s", m.Path, m.Version)
 	}
+	if failed {
+		os.Exit(1)
+	}
 }
 
 func runCmd(dir, name string, args ...string) error {
 	log.Printf("> [%s] %s %s", dir, name, strings.Join(args, " "))
 	cmd := exec.Command(name, args...)
 	cmd.Dir = dir
+	cmd.Stdout = os.Stdout
+	cmd.Stderr = os.Stderr
 	if err := cmd.Start(); err != nil {
 		return fmt.Errorf("Start: %v", err)
 	}
@@ -143,7 +151,8 @@ func process(mod indexEntry, workingDir, outDir string, print bool) error {
 	if err := runCmd(workingDir, "go", "mod", "tidy"); err != nil {
 		return fmt.Errorf("go mod tidy error: %v", err)
 	}
-	if err := runCmd(workingDir, "go", "get", "-d", "-t", mod.Path+"/...@"+mod.Version); err != nil {
+	// Don't do /... because it fails on submodules.
+	if err := runCmd(workingDir, "go", "get", "-d", "-t", mod.Path+"@"+mod.Version); err != nil {
 		return fmt.Errorf("go get %s@%s: %v", mod.Path, mod.Version, err)
 	}