civil: support sql.Scanner and driver.Valuer

[jgiles]

It would be great if e.g. civil.Date was directly usable in SQL queries.

[jba]

Just to clarify: are you using civil.Date with Spanner, or with a SQL system outside of this repo? The database/sql package isn't used by any package in this repo.

[jgiles]

I'm using it with an SQL system outside this repo. I don't really know what will happen with golang/go#19700 (and whether whatever is added looks like this type), but for the time being civil provides a clean version of a widely-useful fundemental type.

If it's not intended for this package to be used more widely, please let me know :-)

Scanner/Valuer seem pretty common on basic types like this, and are very useful.

[jba]

@bradfitz thoughts?

[bradfitz]

Seems reasonable.

[jgiles]

FYI I have a PR in progress, just need to add testing.

[jba]

We don't accept GitHub PRs; we use Gerrit. See CONTRIBUTING.md.

But if you put up a PR, I will make a Gerrit CL for you.

[jeanbza]

cc @shollyman

[skuruppu]

@tbpg would you be able to help us route this issue to the right place? @olavloite and I were looking at this and it doesn't seem like this is related to spanner.

[tbpg]

Spanner and BigQuery are the two importers of the civil package in cloud.google.com/go. So, I think either api: spanner or api: bigquery make the most sense as the owner for this issue.

[skuruppu]

From my understanding of this issue, I think the intention is to add sql.Scanner and driver.Valuer support in https://github.com/googleapis/google-cloud-go/blob/master/civil/civil.go.

I'm not sure who in the Go team maintains that package at the moment. So I might leave it up to the Go team to assign this to the right person.

[codyoss]

Closing due to no traction on this in the last 4ish years