logging: library code should not crash

[ghasemloo]

Client

Stackdriver Logging

Environment

all

Code

replace panics

0d861fa

Expected behavior

library code should not crash (except at startup)

Actual behavior

library code crashes when request is nil

[codyoss]

From looking at both of these they seem like actual valid reasons to panic. I could be missing something though. Did you trigger these panics while your code was running?

[codyoss]

Closing due to lack of response. Please reopen if you have more information to share.

[ghasemloo]

Yes, it did, the request was nil I think.

Based on Google's internal go style library code should not panic: go/gocomments#dont-panic
Filed here instead of internally since this seems to be the source of truth for the code.

[ghasemloo]

@jba fyi