Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Profiler: Go agent should not collect disabled profile types #2835

Closed
kalyanac opened this issue Sep 10, 2020 · 0 comments · Fixed by #2836
Closed

Profiler: Go agent should not collect disabled profile types #2835

kalyanac opened this issue Sep 10, 2020 · 0 comments · Fixed by #2836
Assignees
@kalyanac
Labels
api: cloudprofiler Issues related to the Cloud Profiler API. lang: go Issues specific to Go. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@kalyanac
Copy link
Contributor

Client

Profiler

Environment

Any

Go Environment

$ go version any

Expected behavior

If Profiler agent is started with certain profile types disabled, those profile types should not be collected.

Actual behavior

Profiler agent collects disabled profile types. It should not.
@kalyanac kalyanac added the triage me I really want to be triaged. label Sep 10, 2020
@product-auto-label product-auto-label bot added the api: cloudprofiler Issues related to the Cloud Profiler API. label Sep 10, 2020
@kalyanac kalyanac added lang: go Issues specific to Go. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed triage me I really want to be triaged. labels Sep 10, 2020
@kalyanac kalyanac mentioned this issue Sep 10, 2020
Merged
@tbpg tbpg added the priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. label Sep 10, 2020
kalyanac added a commit that referenced this issue Sep 12, 2020
@kalyanac
fix(profiler): do not collect disabled profile types (#2836)
faeb498 
* fix(profiler): do not collect disabled profile types
Fixes #2835
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kalyanac kalyanac

Labels
api: cloudprofiler Issues related to the Cloud Profiler API. lang: go Issues specific to Go. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(profiler): do not collect disabled profile types
2 participants
@kalyanac @tbpg