Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal/gensnippets: include comment indicating code is autogenerated #4260

Closed
noahdietz opened this issue Jun 14, 2021 · 0 comments · Fixed by #4261
Closed

internal/gensnippets: include comment indicating code is autogenerated #4260

noahdietz opened this issue Jun 14, 2021 · 0 comments · Fixed by #4261
Assignees
@noahdietz
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@noahdietz
Copy link
Contributor

Can we include a comment near the top of the file indicating that the code is autogenerated? I believe this is the (somewhat recently) accepted format of such comments: https://golang.org/cmd/go/#hdr-Generate_Go_files_by_processing_source. I read in the PRD that this should be indicated and noticed it hadn't been added already.

For GAPICs it is // Code generated by protoc-gen-go_gapic. DO NOT EDIT. just under the license block.
@noahdietz noahdietz added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Jun 14, 2021
@noahdietz noahdietz mentioned this issue Jun 14, 2021
Merged
@noahdietz noahdietz self-assigned this Jun 14, 2021
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 14, 2021
@noahdietz
fix(internal): add autogenerated header to snippets (#4261)
2220787 
Fixes #4260
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noahdietz noahdietz

Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(internal): add autogenerated header to snippets noahdietz/google-cloud-go
1 participant
@noahdietz