Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): support AbortIncompleteMultipartUpload LifecycleAction #5812

Merged
merged 14 commits into from Jun 8, 2022
Merged

feat(storage): support AbortIncompleteMultipartUpload LifecycleAction #5812

merged 14 commits into from Jun 8, 2022

Conversation

BrennaEpp
Copy link
Contributor

Fixes #5795

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the Cloud Storage API. labels Mar 29, 2022
@BrennaEpp BrennaEpp marked this pull request as ready for review March 30, 2022 22:49
@BrennaEpp BrennaEpp requested review from a team as code owners March 30, 2022 22:49
@BrennaEpp BrennaEpp added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 30, 2022
@BrennaEpp BrennaEpp mentioned this pull request Mar 30, 2022
Closed
@BrennaEpp BrennaEpp requested a review from tritone March 31, 2022 05:12
tritone
tritone reviewed Mar 31, 2022
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

storage/bucket.go Outdated Show resolved Hide resolved
@product-auto-label product-auto-label bot added the stale: old Pull request is old and needs attention. label Apr 28, 2022
@product-auto-label product-auto-label bot added stale: extraold Pull request is critically old and needs prioritization. and removed stale: old Pull request is old and needs attention. labels May 28, 2022
@tritone tritone removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jun 8, 2022
@tritone tritone merged commit fdec929 into googleapis:main Jun 8, 2022
@release-please release-please bot mentioned this pull request Jun 8, 2022
Merged
@BrennaEpp BrennaEpp deleted the olm branch February 8, 2023 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. size: m Pull request size is medium. stale: extraold Pull request is critically old and needs prioritization.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage: support AbortIncompleteMultipartUpload LifecycleAction
3 participants
@BrennaEpp @tritone @shaffeeullah