internal: move bundler from google.golang.org/api/support/bundler #685
Assignees
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: cleanup
An internal cleanup or hygiene concern.
Comments
|
@mcgreevy Just making sure you're OK with this, since we made it visible for another project you were working on. |
|
We are still using it in the chrome infra code, so it would be good if it could remain public. (FYI I'll be OOO for 2 weeks, so may not reply further on this thread for a while). |
|
Leaving things as they are. |
|
This is definitely a P2-ish issue, but we should decide to either: a) Make this a stable API, in which case I'm not sure it belongs where it is. There aren't that many folks depend on it right now (<10 based on public GitHub data), so it would be easier to do sooner rather than later. |
|
Moving it and making it stable are mostly orthogonal. Why can't it be world-visible (to avoid code duplication) and marked experimental/alpha? I'm not entirely ready to mark the API stable. |
|
I'm not saying we should do it now, but we should have a plan for its future. The world-visible part isn't that bad, but does mean that it can accidentally break people you aren't expecting to break when you make changes. The placement is problematic because you have to update the rest of the API client with it if you want to get a fix. |
pongad
added
the
priority: p2
semistrict
pushed a commit
to semistrict/google-cloud-go
that referenced
this issue
Jun 11, 2018
Fixes census-instrumentation/opencensus-go#683. Count aggregation will always be exported as INT64 MetricDescriptor, no matter whether Measure is INT64 or FLOAT64.
yoshi-automation
added a commit
that referenced
this issue
Nov 19, 2021
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#725 Changes: feat(compute): Switch to string enums for compute (#685) Also introduce gapic_yaml for java clients to override default LRO configuration (which has too way too long timeouts). Also cleanup regenerate other files (grpc_service_config and service yaml) Source-Link: googleapis/googleapis@8ce4ea6 docs(cloudtasks): fix docstring formatting Committer: @parthea PiperOrigin-RevId: 410919520 Source-Link: googleapis/googleapis@b5274f7 build(spanner/admin/database): add published name under submodules PiperOrigin-RevId: 410900101 Source-Link: googleapis/googleapis@c246c88 chore(vmmigration): Prepare vmmigration v1 BUILD.bazel for release PiperOrigin-RevId: 410873197 Source-Link: googleapis/googleapis@6e8a083
yoshi-automation
added a commit
that referenced
this issue
Nov 29, 2021
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#726 Changes: fix(compute): make parent_id fields required compute move and insert methods (#686) Source-Link: googleapis/googleapis@02df998 build(networkconnectivity): correct artifact name for npm PiperOrigin-RevId: 411807571 Source-Link: googleapis/googleapis@221556e docs(retail): Keep the API doc up-to-date feat: update grpc service config settings to reflect correct API deadlines PiperOrigin-RevId: 411660243 Source-Link: googleapis/googleapis@72adf13 feat(servicecontrol): add C++ rules for many Cloud services PiperOrigin-RevId: 411620635 Source-Link: googleapis/googleapis@eddd3d8 build(metastore): correct artifact name for npm PiperOrigin-RevId: 411598711 Source-Link: googleapis/googleapis@970cd21 chore(longrunning): generate java files for google/api chore: generate java files for google/cloud/audit chore: generate java files for google/geo/type chore: generate java files for google/logging/type chore: generate java files for google/longrunning chore: generate java files for google/rpc chore: generate java files for google/rpc/context chore: generate java files for google/type chore: generate java files for google/cloud PiperOrigin-RevId: 411585075 Source-Link: googleapis/googleapis@b21a21e feat(contactcenterinsights): remove feature flag disable_issue_modeling PiperOrigin-RevId: 411140666 Source-Link: googleapis/googleapis@9a182e6 feat(contactcenterinsights): new feature flag disable_issue_modeling docs: fixed formatting issues in the reference documentation PiperOrigin-RevId: 411102531 Source-Link: googleapis/googleapis@68b0c8a feat(securitycenter): Added a new API method UpdateExternalSystem, which enables updating a finding w/ external system metadata. External systems are a child resource under finding, and are housed on the finding itself, and can also be filtered on in Notifications, the ListFindings and GroupFindings API PiperOrigin-RevId: 411093163 Source-Link: googleapis/googleapis@be8f988 feat(compute): Switch to string enums for compute (#685) Also introduce gapic_yaml for java clients to override default LRO configuration (which has too way too long timeouts). Also cleanup regenerate other files (grpc_service_config and service yaml) Source-Link: googleapis/googleapis@8ce4ea6 docs(cloudtasks): fix docstring formatting Committer: @parthea PiperOrigin-RevId: 410919520 Source-Link: googleapis/googleapis@b5274f7 build(spanner/admin/database): add published name under submodules PiperOrigin-RevId: 410900101 Source-Link: googleapis/googleapis@c246c88 chore(vmmigration): Prepare vmmigration v1 BUILD.bazel for release PiperOrigin-RevId: 410873197 Source-Link: googleapis/googleapis@6e8a083
yoshi-automation
added a commit
that referenced
this issue
Nov 29, 2021
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#726 Changes: fix(compute): make parent_id fields required compute move and insert methods (#686) Source-Link: googleapis/googleapis@02df998 build(networkconnectivity): correct artifact name for npm PiperOrigin-RevId: 411807571 Source-Link: googleapis/googleapis@221556e docs(retail): Keep the API doc up-to-date feat: update grpc service config settings to reflect correct API deadlines PiperOrigin-RevId: 411660243 Source-Link: googleapis/googleapis@72adf13 feat(servicecontrol): add C++ rules for many Cloud services PiperOrigin-RevId: 411620635 Source-Link: googleapis/googleapis@eddd3d8 build(metastore): correct artifact name for npm PiperOrigin-RevId: 411598711 Source-Link: googleapis/googleapis@970cd21 chore(longrunning): generate java files for google/api chore: generate java files for google/cloud/audit chore: generate java files for google/geo/type chore: generate java files for google/logging/type chore: generate java files for google/longrunning chore: generate java files for google/rpc chore: generate java files for google/rpc/context chore: generate java files for google/type chore: generate java files for google/cloud PiperOrigin-RevId: 411585075 Source-Link: googleapis/googleapis@b21a21e feat(contactcenterinsights): remove feature flag disable_issue_modeling PiperOrigin-RevId: 411140666 Source-Link: googleapis/googleapis@9a182e6 feat(contactcenterinsights): new feature flag disable_issue_modeling docs: fixed formatting issues in the reference documentation PiperOrigin-RevId: 411102531 Source-Link: googleapis/googleapis@68b0c8a feat(securitycenter): Added a new API method UpdateExternalSystem, which enables updating a finding w/ external system metadata. External systems are a child resource under finding, and are housed on the finding itself, and can also be filtered on in Notifications, the ListFindings and GroupFindings API PiperOrigin-RevId: 411093163 Source-Link: googleapis/googleapis@be8f988 feat(compute): Switch to string enums for compute (#685) Also introduce gapic_yaml for java clients to override default LRO configuration (which has too way too long timeouts). Also cleanup regenerate other files (grpc_service_config and service yaml) Source-Link: googleapis/googleapis@8ce4ea6 docs(cloudtasks): fix docstring formatting Committer: @parthea PiperOrigin-RevId: 410919520 Source-Link: googleapis/googleapis@b5274f7 build(spanner/admin/database): add published name under submodules PiperOrigin-RevId: 410900101 Source-Link: googleapis/googleapis@c246c88 chore(vmmigration): Prepare vmmigration v1 BUILD.bazel for release PiperOrigin-RevId: 410873197 Source-Link: googleapis/googleapis@6e8a083
codyoss
pushed a commit
that referenced
this issue
Dec 3, 2021
This is an auto-generated regeneration of the gapic clients by cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is submitted, genbot will update this PR with a newer dependency to the newer version of genproto and assign reviewers to this PR. If you have been assigned to review this PR, please: - Ensure that the version of genproto in go.mod has been updated. - Ensure that CI is passing. If it's failing, it requires your manual attention. - Approve and submit this PR if you believe it's ready to ship. Corresponding genproto PR: googleapis/go-genproto#726 Changes: fix(compute): make parent_id fields required compute move and insert methods (#686) Source-Link: googleapis/googleapis@02df998 build(networkconnectivity): correct artifact name for npm PiperOrigin-RevId: 411807571 Source-Link: googleapis/googleapis@221556e docs(retail): Keep the API doc up-to-date feat: update grpc service config settings to reflect correct API deadlines PiperOrigin-RevId: 411660243 Source-Link: googleapis/googleapis@72adf13 feat(servicecontrol): add C++ rules for many Cloud services PiperOrigin-RevId: 411620635 Source-Link: googleapis/googleapis@eddd3d8 build(metastore): correct artifact name for npm PiperOrigin-RevId: 411598711 Source-Link: googleapis/googleapis@970cd21 chore(longrunning): generate java files for google/api chore: generate java files for google/cloud/audit chore: generate java files for google/geo/type chore: generate java files for google/logging/type chore: generate java files for google/longrunning chore: generate java files for google/rpc chore: generate java files for google/rpc/context chore: generate java files for google/type chore: generate java files for google/cloud PiperOrigin-RevId: 411585075 Source-Link: googleapis/googleapis@b21a21e feat(contactcenterinsights): remove feature flag disable_issue_modeling PiperOrigin-RevId: 411140666 Source-Link: googleapis/googleapis@9a182e6 feat(contactcenterinsights): new feature flag disable_issue_modeling docs: fixed formatting issues in the reference documentation PiperOrigin-RevId: 411102531 Source-Link: googleapis/googleapis@68b0c8a feat(securitycenter): Added a new API method UpdateExternalSystem, which enables updating a finding w/ external system metadata. External systems are a child resource under finding, and are housed on the finding itself, and can also be filtered on in Notifications, the ListFindings and GroupFindings API PiperOrigin-RevId: 411093163 Source-Link: googleapis/googleapis@be8f988 feat(compute): Switch to string enums for compute (#685) Also introduce gapic_yaml for java clients to override default LRO configuration (which has too way too long timeouts). Also cleanup regenerate other files (grpc_service_config and service yaml) Source-Link: googleapis/googleapis@8ce4ea6 docs(cloudtasks): fix docstring formatting Committer: @parthea PiperOrigin-RevId: 410919520 Source-Link: googleapis/googleapis@b5274f7 build(spanner/admin/database): add published name under submodules PiperOrigin-RevId: 410900101 Source-Link: googleapis/googleapis@c246c88 chore(vmmigration): Prepare vmmigration v1 BUILD.bazel for release PiperOrigin-RevId: 410873197 Source-Link: googleapis/googleapis@6e8a083
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@jba AFAICT, bundler is only used inside cloud.google.com/go/, not in the generated APIs. Especially since the API is unstable, it makes more sense to me to move it into this repository as a private package.
The text was updated successfully, but these errors were encountered: