feat(internal/kokoro): add script to test compatibility with samples#2637
Merged
codyoss merged 4 commits intogoogleapis:masterfrom Aug 5, 2020
codyoss:samples
Merged
feat(internal/kokoro): add script to test compatibility with samples#2637codyoss merged 4 commits intogoogleapis:masterfrom codyoss:samples
codyoss merged 4 commits intogoogleapis:masterfrom
codyoss:samples
Conversation
This is currently blocked by the following issue: - GoogleCloudPlatform/golang-samples#1603
google-cla
bot
added
the
cla: yes
codyoss
added
do not merge
google-cla
bot
added
the
cla: yes
Logic borrowed from the samples repo
tbpg
suggested changes
Aug 3, 2020
Contributor
tbpg
left a comment
tbpg
left a comment
There was a problem hiding this comment.
Can we tie this into a build so we can run the script as part of this PR? Might also be good to make a temporary breaking change to this PR to make sure this script catches it.
Member
Author
|
Sure thing! |
Member
Author
|
Ran off of presubmit. Note I would like to eventually run this as another child job vs running another script off of our presubmit script. This way it all happens in parallel. This did pass as expected, with my next commit I will break an api that our samples cover to show this works. |
Member
Author
|
@tbpg I will revert these changes so that the we can kick this job off as its own child job, but I first wanted to make sure you got to see the failure. From the build logs ...
# github.com/GoogleCloudPlatform/golang-samples/appengine/go11x/tasks/create_task
appengine/go11x/tasks/create_task/create_task.go:60:19: assignment mismatch: 2 variables but 3 values
# github.com/GoogleCloudPlatform/golang-samples/tasks
tasks/create_http_task.go:60:19: assignment mismatch: 2 variables but 3 values
# github.com/GoogleCloudPlatform/golang-samples/tasks/token
tasks/token/create_http_task_with_token.go:64:19: assignment mismatch: 2 variables but 3 values |
tbpg
approved these changes
Aug 5, 2020
codyoss
removed
the
do not merge
tritone
pushed a commit
to tritone/google-cloud-go
that referenced
this pull request
Aug 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is currently blocked by the following issue:
Note, this is not plumbed through yet.