Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal/kokoro): add script to test compatibility with samples #2637

Merged
merged 4 commits into from Aug 5, 2020

Conversation

@codyoss
Copy link
Member

@codyoss codyoss commented Jul 24, 2020

This is currently blocked by the following issue:

Note, this is not plumbed through yet.

This is currently blocked by the following issue:
  - GoogleCloudPlatform/golang-samples#1603
@codyoss codyoss requested review from broady and tbpg as code owners Jul 24, 2020
@google-cla google-cla bot added the cla: yes label Jul 24, 2020
@google-cla google-cla bot added the cla: yes label Jul 24, 2020
codyoss added 2 commits Jul 24, 2020
Logic borrowed from the samples repo
Copy link
Collaborator

@tbpg tbpg left a comment

Can we tie this into a build so we can run the script as part of this PR? Might also be good to make a temporary breaking change to this PR to make sure this script catches it.

@codyoss
Copy link
Member Author

@codyoss codyoss commented Aug 4, 2020

Sure thing!

@codyoss
Copy link
Member Author

@codyoss codyoss commented Aug 4, 2020

Ran off of presubmit. Note I would like to eventually run this as another child job vs running another script off of our presubmit script. This way it all happens in parallel. This did pass as expected, with my next commit I will break an api that our samples cover to show this works.

@codyoss
Copy link
Member Author

@codyoss codyoss commented Aug 4, 2020

@tbpg I will revert these changes so that the we can kick this job off as its own child job, but I first wanted to make sure you got to see the failure. From the build logs

...
# github.com/GoogleCloudPlatform/golang-samples/appengine/go11x/tasks/create_task
appengine/go11x/tasks/create_task/create_task.go:60:19: assignment mismatch: 2 variables but 3 values
# github.com/GoogleCloudPlatform/golang-samples/tasks
tasks/create_http_task.go:60:19: assignment mismatch: 2 variables but 3 values
# github.com/GoogleCloudPlatform/golang-samples/tasks/token
tasks/token/create_http_task_with_token.go:64:19: assignment mismatch: 2 variables but 3 values
@tbpg
tbpg approved these changes Aug 5, 2020
@codyoss codyoss force-pushed the codyoss:samples branch from cd76d45 to 9646f95 Aug 5, 2020
@codyoss codyoss merged commit f2aa76a into googleapis:master Aug 5, 2020
2 checks passed
2 checks passed
@google-cla
cla/google All necessary CLAs are signed
@kokoro-team
kokoro Kokoro CI build successful
Details
@codyoss codyoss deleted the codyoss:samples branch Aug 5, 2020
tritone added a commit to tritone/google-cloud-go that referenced this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants