Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(functions/metadata): Special-case marshaling #2669

Merged

Conversation

@juliehockett
Copy link
Contributor

@juliehockett juliehockett commented Jul 31, 2020

Handle the RawPath element during marshaling in the same way as during unmarshaling.

Handle the RawPath element during marshalling in the same way as during
unmarshalling.
functions/metadata/metadata.go Outdated Show resolved Hide resolved
@juliehockett
Copy link
Contributor Author

@juliehockett juliehockett commented Aug 3, 2020

Is there something I'm missing that will get the kokoro build to trigger?

Copy link
Collaborator

@tbpg tbpg left a comment

Kokoro should kick off automatically for organization members. Not sure why it didn't.

functions/metadata/metadata_test.go Show resolved Hide resolved
@codyoss
codyoss approved these changes Aug 4, 2020
Copy link
Member

@codyoss codyoss left a comment

LGTM

@tbpg
tbpg approved these changes Aug 4, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit d8d7fc6 into googleapis:master Aug 4, 2020
2 checks passed
2 checks passed
@google-cla
cla/google All necessary CLAs are signed
@kokoro-team
kokoro Kokoro CI build successful
Details
@juliehockett juliehockett deleted the juliehockett:functions-resource-marshall branch Aug 4, 2020
tritone added a commit to tritone/google-cloud-go that referenced this pull request Aug 25, 2020
Handle the RawPath element during marshaling in the same way as during unmarshaling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants