Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(functions/metadata): Special-case marshaling #2669

Merged

Conversation

roffjulie
Copy link
Contributor

Handle the RawPath element during marshaling in the same way as during unmarshaling.

Handle the RawPath element during marshalling in the same way as during
unmarshalling.
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2020
@roffjulie
Copy link
Contributor Author

Is there something I'm missing that will get the kokoro build to trigger?

Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kokoro should kick off automatically for organization members. Not sure why it didn't.

functions/metadata/metadata_test.go Show resolved Hide resolved
@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 4, 2020
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbpg tbpg added automerge Merge the pull request once unit tests and other checks pass. kokoro:run Add this label to force Kokoro to re-run the tests. labels Aug 4, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Aug 4, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit d8d7fc6 into googleapis:master Aug 4, 2020
@roffjulie roffjulie deleted the functions-resource-marshall branch August 4, 2020 17:30
tritone pushed a commit to tritone/google-cloud-go that referenced this pull request Aug 25, 2020
Handle the RawPath element during marshaling in the same way as during unmarshaling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants