Skip to content

fix(all): correct minor typos#2756

Merged
tbpg merged 2 commits intogoogleapis:masterfrom
aurkenb:master
Aug 20, 2020
Merged

fix(all): correct minor typos#2756
tbpg merged 2 commits intogoogleapis:masterfrom
aurkenb:master

Conversation

@aurkenb
Copy link
Copy Markdown
Contributor

@aurkenb aurkenb commented Aug 20, 2020

No description provided.

@google-cla
Copy link
Copy Markdown

google-cla bot commented Aug 20, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 20, 2020
@aurkenb
Copy link
Copy Markdown
Contributor Author

aurkenb commented Aug 20, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 20, 2020
Copy link
Copy Markdown
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let us know when you get the CLA sorted out. [edit: it's sorted 😄)

Comment thread redis/apiv1beta1/cloud_redis_client.go Outdated
// /projects/{project_id}/locations/{location_id}/instances/{instance_id}
//
// Note that location_id must be refering to a GCP region; for example:
// Note that location_id must be referring to a GCP region; for example:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto-generated from this proto. I'll look into getting that fixed internally. Will you revert this file for this PR?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks tbpg! Already reverted this file.

@aurkenb
Copy link
Copy Markdown
Contributor Author

aurkenb commented Aug 20, 2020

Done!

@aurkenb aurkenb requested a review from tbpg August 20, 2020 13:27
@codyoss codyoss added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 20, 2020
@tbpg tbpg merged commit 03d78b5 into googleapis:master Aug 20, 2020
tritone pushed a commit to tritone/google-cloud-go that referenced this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants