fix(all): correct minor typos#2756
Merged
tbpg merged 2 commits intogoogleapis:masterfrom Aug 20, 2020
aurkenb:master
Merged
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
@googlebot I signed it! |
tbpg
suggested changes
Aug 20, 2020
| // /projects/{project_id}/locations/{location_id}/instances/{instance_id} | ||
| // | ||
| // Note that location_id must be refering to a GCP region; for example: | ||
| // Note that location_id must be referring to a GCP region; for example: |
Contributor
There was a problem hiding this comment.
This file is auto-generated from this proto. I'll look into getting that fixed internally. Will you revert this file for this PR?
Contributor
Author
There was a problem hiding this comment.
Thanks tbpg! Already reverted this file.
Contributor
Author
|
Done! |
codyoss
approved these changes
Aug 20, 2020
tbpg
approved these changes
Aug 20, 2020
tritone
pushed a commit
to tritone/google-cloud-go
that referenced
this pull request
Aug 25, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.