Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(all): correct minor typos #2756

Merged
merged 2 commits into from Aug 20, 2020
Merged

fix(all): correct minor typos #2756

merged 2 commits into from Aug 20, 2020

Conversation

@aurkenb
Copy link
Contributor

@aurkenb aurkenb commented Aug 20, 2020

No description provided.

@aurkenb aurkenb requested review from codyoss, shollyman and tbpg as code owners Aug 20, 2020
@google-cla
Copy link

@google-cla google-cla bot commented Aug 20, 2020

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Aug 20, 2020
@aurkenb
Copy link
Contributor Author

@aurkenb aurkenb commented Aug 20, 2020

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Aug 20, 2020
Copy link
Collaborator

@tbpg tbpg left a comment

Thanks! Let us know when you get the CLA sorted out. [edit: it's sorted 😄)

@@ -117,7 +117,7 @@ type CloudRedisClient struct {
// As such, Redis instances are resources of the form:
// /projects/{project_id}/locations/{location_id}/instances/{instance_id}
//
// Note that location_id must be refering to a GCP region; for example:
// Note that location_id must be referring to a GCP region; for example:

This comment has been minimized.

@tbpg

tbpg Aug 20, 2020
Collaborator

This file is auto-generated from this proto. I'll look into getting that fixed internally. Will you revert this file for this PR?

This comment has been minimized.

@aurkenb

aurkenb Aug 20, 2020
Author Contributor

Thanks tbpg! Already reverted this file.

@aurkenb
Copy link
Contributor Author

@aurkenb aurkenb commented Aug 20, 2020

Done!

@tbpg
tbpg approved these changes Aug 20, 2020
@tbpg tbpg merged commit 03d78b5 into googleapis:master Aug 20, 2020
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
tritone added a commit to tritone/google-cloud-go that referenced this pull request Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants