Skip to content

feat(bigquery): add support for bignumeric #2779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 19, 2020
Merged

feat(bigquery): add support for bignumeric #2779

merged 11 commits into from
Nov 19, 2020

Conversation

shollyman
Copy link
Contributor

@shollyman shollyman commented Aug 26, 2020 •
edited
Loading

This PR adds basic support for the BIGNUMERIC type in BigQuery.

This library has several cases where it tries to infer the appropriate BigQuery type from a native Go type. For big.Rat types, we continue the existing behavior of mapping them to NUMERIC, as the big.Rat doesn't
provide a general way of indicating desired precision or scale to determine whether BIGNUMERIC is a more
appropriate mapping.

@shollyman shollyman added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 26, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 26, 2020
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Aug 27, 2020
@shollyman shollyman requested a review from a team as a code owner November 17, 2020 21:14
tbpg
tbpg suggested changes Nov 18, 2020
View reviewed changes
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the PR body? Or accidental review request?

I'm not familiar with this code. So, it seems to make sense, but this is mostly a style review.

tbpg
tbpg approved these changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@tbpg tbpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Partial digit" question is still open, otherwise LGTM.

@shollyman shollyman merged commit ea3cde5 into googleapis:master Nov 19, 2020
@shollyman shollyman deleted the fr-bignumeric branch November 19, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbpg tbpg tbpg approved these changes

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shollyman @tbpg