Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigquery): add support for bignumeric #2779

Merged
merged 11 commits into from Nov 19, 2020

Conversation

@shollyman
Copy link
Contributor

@shollyman shollyman commented Aug 26, 2020

This PR adds basic support for the BIGNUMERIC type in BigQuery.

This library has several cases where it tries to infer the appropriate BigQuery type from a native Go type. For big.Rat types, we continue the existing behavior of mapping them to NUMERIC, as the big.Rat doesn't
provide a general way of indicating desired precision or scale to determine whether BIGNUMERIC is a more
appropriate mapping.

@shollyman shollyman requested a review from as a code owner Nov 17, 2020
Copy link
Collaborator

@tbpg tbpg left a comment

Need to update the PR body? Or accidental review request?

I'm not familiar with this code. So, it seems to make sense, but this is mostly a style review.

Loading

bigquery/params.go Outdated Show resolved Hide resolved
Loading
bigquery/schema.go Outdated Show resolved Hide resolved
Loading
bigquery/value.go Outdated Show resolved Hide resolved
Loading
bigquery/value_test.go Outdated Show resolved Hide resolved
Loading
tbpg
tbpg approved these changes Nov 19, 2020
Copy link
Collaborator

@tbpg tbpg left a comment

"Partial digit" question is still open, otherwise LGTM.

Loading

@shollyman shollyman merged commit ea3cde5 into googleapis:master Nov 19, 2020
3 checks passed
Loading
@shollyman shollyman deleted the fr-bignumeric branch Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants