Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(workflows): start generating apiv1beta #2799

Merged
merged 1 commit into from
Aug 31, 2020
Merged

feat(workflows): start generating apiv1beta #2799

merged 1 commit into from
Aug 31, 2020

Conversation

codyoss
Copy link
Member

@codyoss codyoss commented Aug 31, 2020

No description provided.

@codyoss codyoss requested a review from tbpg as a code owner August 31, 2020 18:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2020
@@ -838,5 +838,13 @@
"client_library_type": "generated",
"docs_url": "https://pkg.go.dev/cloud.google.com/go/webrisk/apiv1beta1",
"release_level": "beta"
},
"cloud.google.com/go/workflows/apiv1beta": {
"distribution_name": "cloud.google.com/go/workflows/apiv1beta",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apiv1beta, not apiv1beta1? Generation works, so this seems correct, but wanted to confirm since this flows into package name.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, apiv1beta. Historically if the pathing in googleapis does not contain a number suffix neither does our package here.

@tbpg tbpg added the automerge Merge the pull request once unit tests and other checks pass. label Aug 31, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 0e39665 into googleapis:master Aug 31, 2020
@codyoss codyoss deleted the wf-gen branch August 31, 2020 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants