Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cloudbuild): Start generating apiv1/v3 #2830

Merged
merged 2 commits into from Sep 9, 2020

Conversation

@codyoss
Copy link
Member

@codyoss codyoss commented Sep 9, 2020

A recent change has removed some apis from the surface of
apiv1/v2. As this is a breaking change, we need to start generating
sources under a new import path. A future commit will deprecated
the previous package.

A recent change[1] has removed some apis from the surface of
apiv1/v2. As this is a breaking change, we need to start generating
sources under a new import path. A future commit will deprecated
the previous package.

[1]: googleapis/googleapis@48ce887
@codyoss codyoss requested a review from tbpg as a code owner Sep 9, 2020
@google-cla google-cla bot added the cla: yes label Sep 9, 2020
@tbpg
tbpg approved these changes Sep 9, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 358a536 into googleapis:master Sep 9, 2020
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
codyoss added a commit to codyoss/google-cloud-go that referenced this pull request Sep 10, 2020
The breaking changes have been rolled back, there is no need to
generate under a new package.

This reverts commit 358a536.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants