Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsub): add flush method to topic #2863

Merged
merged 10 commits into from May 24, 2021

Conversation

@hongalex
Copy link
Member

@hongalex hongalex commented Sep 15, 2020

To complement the FlushAndStop method, add a Flush method that flushes all publishes topics but does not stop the topic.

Closes #1831

@google-cla google-cla bot added the cla: yes label Sep 15, 2020
@hongalex hongalex changed the title Pubsub topic flush feat(pubsub): add flush method to topic Sep 15, 2020
@hongalex hongalex requested review from as code owners Apr 1, 2021
codyoss
codyoss approved these changes Apr 2, 2021
Copy link
Member

@codyoss codyoss left a comment

Just a couple of comments, but LGTM.

Loading

pubsub/topic.go Outdated Show resolved Hide resolved
Loading
pubsub/topic.go Show resolved Hide resolved
Loading
@hongalex hongalex merged commit 825ddd6 into googleapis:master May 24, 2021
3 checks passed
Loading
@hongalex hongalex deleted the pubsub-topic-flush branch May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants