Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datastore): increase deferred key iter limit #2878

Merged
merged 3 commits into from Sep 17, 2020

Conversation

@tritone
Copy link
Collaborator

@tritone tritone commented Sep 17, 2020

A customer was hitting the upper bound for iteration through
deferred keys, and the logic underlying the 100 iteration limit
was flawed. Based on internal discussions and what's happening
in other clients, it's fine to increase this value.

A customer was hitting the upper bound for iteration through
deferred keys, and the logic underlying the 100 iteration limit
was flawed. Based on internal discussions and what's happening
in other clients, it's fine to increase this value.
@tritone tritone requested review from codyoss and tbpg Sep 17, 2020
@google-cla google-cla bot added the cla: yes label Sep 17, 2020
@tritone
Copy link
Collaborator Author

@tritone tritone commented Sep 17, 2020

Loading

Copy link
Member

@codyoss codyoss left a comment

LGTM

Loading

@BenWhitehead
Copy link

@BenWhitehead BenWhitehead commented Sep 17, 2020

Thanks for looking into this @tritone!

Loading

@gcf-merge-on-green gcf-merge-on-green bot merged commit 7f1057a into googleapis:master Sep 17, 2020
3 checks passed
Loading
@tritone tritone deleted the ds-iter-fix branch Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants