Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(translate): properly name examples #2892

merged 2 commits into from Sep 18, 2020


Copy link

@codyoss codyoss commented Sep 18, 2020

Fixes: #2883

@codyoss codyoss requested a review from googleapis/yoshi-go-admins as a code owner Sep 18, 2020
@google-cla google-cla bot added the cla: yes label Sep 18, 2020
Copy link
Member Author

@codyoss codyoss commented Sep 18, 2020

These were the only offenders I found, did you have a list somewhere @tbpg?

tbpg approved these changes Sep 18, 2020
Copy link

@tbpg tbpg left a comment

Thank you! I took a look through grep -RE 'func Example[a-zA-Z]*_[A-Z]' and didn't notice anything in particular...

@gcf-merge-on-green gcf-merge-on-green bot merged commit c19e141 into googleapis:master Sep 18, 2020
3 checks passed
3 checks passed
cla/google All necessary CLAs are signed
kokoro Kokoro CI build successful
gcf-merge-on-green bot pushed a commit that referenced this pull request Sep 29, 2020
🤖 I have created a release \*beep\* \*boop\* 
## [0.67.0]( (2020-09-29)

### Features

* **all:** auto-regenerate gapics , refs [#2933]( [#2919]( [#2913]( [#2910]( [#2899]( [#2897]( [#2886]( [#2877]( [#2869]( [#2864](
* **assuredworkloads:** start generating apiv1beta1 ([#2866]( ([7598c4d](
* **dialogflow/cx:** start generating apiv3beta1 ([#2875]( ([37ca93a](
* **docfx:** add support for examples ([#2884]( ([0cc0de3](
* **godocfx:** include README in output ([#2927]( ([f084690](
* **talent:** start generating apiv4 ([#2871]( ([5c98071](

### Bug Fixes

* **godocfx:** filter out other modules, sort pkgs ([#2894]( ([868db45](
* **godocfx:** shorten function names ([#2880]( ([48a0217](
* **translate:** properly name examples ([#2892]( ([c19e141](, refs [#2883](

This PR was generated with [Release Please](
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants