Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(all): update all #2958

Merged
merged 3 commits into from Oct 5, 2020
Merged

Conversation

@renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Oct 5, 2020

This PR contains the following updates:

Package Type Update Change
cloud.google.com/go require minor v0.66.0 -> v0.67.0
golang.org/x/net require digest 5d4f700 -> 0a1ea39
golang.org/x/sync require digest 6e8e738 -> 3042136

Release Notes

googleapis/google-cloud-go

v0.67.0

Compare Source

Features
Bug Fixes

Renovate configuration

📅 Schedule: "before 3am on Monday" (UTC).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot requested review from skuruppu, tritone and googleapis/yoshi-go-admins as code owners Oct 5, 2020
@google-cla google-cla bot added the cla: yes label Oct 5, 2020
@codyoss
codyoss approved these changes Oct 5, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit c317b1f into googleapis:master Oct 5, 2020
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
@dsymonds
Copy link
Contributor

@dsymonds dsymonds commented Dec 3, 2020

Hey @codyoss, what's the deal with this PR adding spanner/spansql/test.txt? It looks to be some sort of fuzzing junk?

@codyoss
Copy link
Member

@codyoss codyoss commented Dec 3, 2020

@dsymonds I am sorry about that, it looks like when I did a go mod tidy I did not have a clean branch and did indeed have a fuzzing related file in my tree. I will open a PR to get that removed.

@dsymonds
Copy link
Contributor

@dsymonds dsymonds commented Dec 3, 2020

No sweat. If those files regularly pop into existence in developer's working trees, they should go in a .gitignore file to prevent future accidents.

But this PR looks like an automated robot created it, so I am a bit confused why it picked up your unclean branch. And there's clearly a bit of a gap in the review process if you didn't catch it before approving.

@codyoss
Copy link
Member

@codyoss codyoss commented Dec 3, 2020

But this PR looks like an automated robot created it

Nope, this is all on me. I also commited to this PR to make CI pass.(The bot is not always smart enough to go mod tidy after updates, at least not a go1.15 go mod tidy) It must have been around the time I was testing some of the fuzzing stuff.

codyoss added a commit to codyoss/google-cloud-go that referenced this pull request Dec 3, 2020
This file was accidentally commited in googleapis#2958.
gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 3, 2020
This file was accidentally commited in #2958.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants