Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): add missing StorageClass in BucketAttrsToUpdate #3038

Merged
merged 6 commits into from Dec 3, 2020

Conversation

@AlisskaPie
Copy link
Contributor

@AlisskaPie AlisskaPie commented Oct 16, 2020

No description provided.

@google-cla google-cla bot added the cla: yes label Oct 16, 2020
@AlisskaPie AlisskaPie marked this pull request as ready for review Oct 16, 2020
@AlisskaPie AlisskaPie requested a review from tritone as a code owner Oct 16, 2020
@AlisskaPie AlisskaPie requested a review from frankyn Oct 16, 2020
Copy link
Collaborator

@tritone tritone left a comment

Looks good to me! Will merge when you stamp @frankyn

Loading

@AlisskaPie
Copy link
Contributor Author

@AlisskaPie AlisskaPie commented Oct 29, 2020

Gentle ping

Loading

@tbpg
Copy link
Collaborator

@tbpg tbpg commented Dec 1, 2020

@tritone @frankyn, are we good to merge this?

Loading

frankyn
frankyn approved these changes Dec 2, 2020
@frankyn
Copy link
Member

@frankyn frankyn commented Dec 2, 2020

Apologies for the lag here, totally missed this.

Loading

@tritone tritone merged commit 2fa1b72 into googleapis:master Dec 3, 2020
3 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants