Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spanner/spannertest): fix ORDER BY combined with SELECT aliases #3043

Merged
merged 1 commit into from Oct 18, 2020

Conversation

dsymonds
Copy link
Contributor

@dsymonds dsymonds commented Oct 18, 2020

This was broken due to the ORDER BY implementation that was a bit of a
hack. Replace that hack with a more explicit evaluation of the ORDER BY
sort keys, which also removed a duplicate chunk of row sorting code.

This also required a restructuring of how locking works during an
evaluation, which cleaned up some other code.

Also include a minor revision to README.md.

This was broken due to the ORDER BY implementation that was a bit of a
hack. Replace that hack with a more explicit evaluation of the ORDER BY
sort keys, which also removed a duplicate chunk of row sorting code.

This also required a restructuring of how locking works during an
evaluation, which cleaned up some other code.
@dsymonds dsymonds added the api: spanner Issues related to the Cloud Spanner API. label Oct 18, 2020
@dsymonds dsymonds requested a review from olavloite Oct 18, 2020
@dsymonds dsymonds requested a review from skuruppu as a code owner Oct 18, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 18, 2020
Copy link
Contributor

@olavloite olavloite left a comment

LGTM, with a suggestion on adding support for ORDER BY on aliases.

spanner/spannertest/db_query.go Show resolved Hide resolved
@dsymonds dsymonds merged commit 89a9df5 into googleapis:master Oct 18, 2020
2 checks passed
@dsymonds dsymonds deleted the spannertest-order-by branch Oct 18, 2020
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Cloud Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants