feat(pubsublite): Retryable stream wrapper#3068
Conversation
|
This is loosely based on https://github.com/googleapis/google-cloud-go/blob/master/pubsub/pullstream.go. An example of usage will be the publisher (not ready for review yet): I will consolidate unit tests for the publisher and retryableStream, as there is much overlap. |
codyoss
left a comment
There was a problem hiding this comment.
I think it would be valuable to add some tests here to ensure no deadlocks/races.
|
Thanks Cody. Yes, definitely need tests! Since retryableStream needs a concrete client stream to operate on, there will be substantial overlap with [unit tests](https://github.com/tmdiep/google-cloud-go/blob/working/pubsublite/publisher_internal_test.go] for the upcoming publisher. |
|
Thanks everyone for reviewing. Merging.. |
This will be used to manage all of Pub/Sub Lite's bidi streaming RPCs: publish, subscribe, streaming cursor commit, partition assignment, etc.