Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(internal): auto-run godocfx on new mods #3069

Merged
merged 3 commits into from Oct 22, 2020
Merged

Conversation

@tbpg
Copy link
Collaborator

@tbpg tbpg commented Oct 22, 2020

This uses index.golang.org to list all modules since a given time. For
example, see
https://index.golang.org/index?since=2019-04-10T19:08:52.997264Z. Each
page is listed in chronological order and is limited to 2000 entries (as
of today).

This stores the last successful time in Datastore. If there is no time in
Datastore, it defaults to 10 days ago.

There is a bit of indirection with interfaces to enable testing.

In the future, we should add the ability to regenerate the YAML for the
latest version of all modules.

cc @julieqiu @katiehockman

This uses index.golang.org to list all modules since a given time. For
example, see
https://index.golang.org/index?since=2019-04-10T19:08:52.997264Z. Each
page is listed in chronological order and is limited to 2000 entries (as
of today).

This stores the last successful time in Datastore. If there is no time in
Datastore, it defaults to 10 days ago.

There is a bit of indirection with interfaces to enable testing.

In the future, we should add the ability to regenerate the YAML for the
latest version of all modules.
@tbpg tbpg requested a review from codyoss Oct 22, 2020
@tbpg tbpg requested a review from googleapis/yoshi-go-admins as a code owner Oct 22, 2020
@google-cla google-cla bot added the cla: yes label Oct 22, 2020
Copy link
Member

@codyoss codyoss left a comment

LGTM

internal/godocfx/timesaver.go Show resolved Hide resolved
Copy link
Collaborator Author

@tbpg tbpg left a comment

Thanks!

internal/godocfx/timesaver.go Show resolved Hide resolved
@tbpg tbpg added the automerge label Oct 22, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 49f497e into master Oct 22, 2020
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
@gcf-merge-on-green gcf-merge-on-green bot deleted the auto-godocfx branch Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants