Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(all): auto-regenerate gapics #3073

Merged
merged 3 commits into from
Oct 26, 2020
Merged

feat(all): auto-regenerate gapics #3073

merged 3 commits into from
Oct 26, 2020

Conversation

yoshi-automation
Copy link
Contributor

This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

  • Ensure that the version of genproto in go.mod has been updated.
  • Ensure that CI is passing. If it's failing, it requires your manual attention.
  • Approve and submit this PR if you believe it's ready to ship.

Corresponding genproto PR: googleapis/go-genproto#470

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2020
yoshi-automation added a commit to googleapis/go-genproto that referenced this pull request Oct 22, 2020
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#3073
codyoss pushed a commit to googleapis/go-genproto that referenced this pull request Oct 22, 2020
This is an auto-generated regeneration of the .pb.go files by
cloud.google.com/go/internal/gapicgen. Once this PR is submitted, genbot will
update the corresponding PR to depend on the newer version of go-genproto, and
assign reviewers. Whilst this or any regen PR is open in go-genproto, genbot
will not create any more regeneration PRs. If all regen PRs are closed,
gapicgen will create a new set of regeneration PRs once per night.

If you have been assigned to review this PR, please:

- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship. That will prompt
genbot to assign reviewers to the google-cloud-go PR.

Corresponding google-cloud-go PR: googleapis/google-cloud-go#3073
@yoshi-automation yoshi-automation marked this pull request as ready for review October 22, 2020 18:30
0xSage
0xSage previously approved these changes Oct 22, 2020
@shinfan
Copy link

shinfan commented Oct 22, 2020

Can we please merge this? @nicoleczhu This is blocking the DCA test automation.

@codyoss
Copy link
Member

codyoss commented Oct 22, 2020

@shinfan This PR will not be merged as is, as it causes some regressions.

@0xSage 0xSage dismissed their stale review October 22, 2020 21:40

kokoro build is failing suddenly

@yoshi-automation yoshi-automation force-pushed the regen_gocloud branch 3 times, most recently from 612ab8e to f5d17cf Compare October 23, 2020 16:05
This is an auto-generated regeneration of the gapic clients by
cloud.google.com/go/internal/gapicgen. Once the corresponding genproto PR is
submitted, genbot will update this PR with a newer dependency to the newer
version of genproto and assign reviewers to this PR.

If you have been assigned to review this PR, please:

- Ensure that the version of genproto in go.mod has been updated.
- Ensure that CI is passing. If it's failing, it requires your manual attention.
- Approve and submit this PR if you believe it's ready to ship.

Corresponding genproto PR: googleapis/go-genproto#470
Copy link
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with google.golang.org/api that has the fix to get these changes in.

@codyoss codyoss merged commit f746cfe into master Oct 26, 2020
@codyoss codyoss deleted the regen_gocloud branch October 26, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants