Skip to content

feat(pubsublite): Publish settings and errors#3075

Merged
tmdiep merged 9 commits intogoogleapis:masterfrom
tmdiep:publish_settings
Oct 28, 2020
Merged

feat(pubsublite): Publish settings and errors#3075
tmdiep merged 9 commits intogoogleapis:masterfrom
tmdiep:publish_settings

Conversation

@tmdiep
Copy link
Copy Markdown
Contributor

@tmdiep tmdiep commented Oct 23, 2020

PublishSettings are almost identical to pubsub.PublishSettings.

Some max thresholds were changed to be consistent with the Pub/Sub Lite Java client library.

@tmdiep tmdiep requested a review from a team October 23, 2020 00:24
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 23, 2020
@tmdiep tmdiep requested a review from hongalex October 23, 2020 00:25
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the Pub/Sub Lite API. label Oct 23, 2020
Copy link
Copy Markdown
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but will defer to Alex

Comment thread pubsublite/settings.go
Comment thread pubsublite/settings_test.go
@tmdiep tmdiep requested a review from hongalex October 27, 2020 19:38
@tmdiep tmdiep merged commit 9eb9fcb into googleapis:master Oct 28, 2020
@tmdiep tmdiep deleted the publish_settings branch October 28, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the Pub/Sub Lite API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants