Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pubsublite): Publish settings and errors #3075

Merged
merged 9 commits into from Oct 28, 2020

Conversation

@tmdiep
Copy link
Contributor

@tmdiep tmdiep commented Oct 23, 2020

PublishSettings are almost identical to pubsub.PublishSettings.

Some max thresholds were changed to be consistent with the Pub/Sub Lite Java client library.

@tmdiep tmdiep requested a review from googleapis/yoshi-go-admins as a code owner Oct 23, 2020
@google-cla google-cla bot added the cla: yes label Oct 23, 2020
@tmdiep tmdiep requested a review from hongalex Oct 23, 2020
Copy link
Member

@codyoss codyoss left a comment

LGTM, but will defer to Alex

pubsublite/settings.go Show resolved Hide resolved
pubsublite/settings_test.go Show resolved Hide resolved
@tmdiep tmdiep force-pushed the tmdiep:publish_settings branch from 5f831ee to e350459 Oct 27, 2020
@tmdiep tmdiep requested a review from hongalex Oct 27, 2020
hongalex and others added 2 commits Oct 27, 2020
@tmdiep tmdiep merged commit 9eb9fcb into googleapis:master Oct 28, 2020
3 checks passed
3 checks passed
@google-cla
cla/google All necessary CLAs are signed
@conventional-commit-lint-gcf
conventionalcommits.org
Details
@kokoro-team
kokoro Kokoro CI build successful
Details
@tmdiep tmdiep deleted the tmdiep:publish_settings branch Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants