fix(logging): do not panic in library code#3076
fix(logging): do not panic in library code#3076gcf-merge-on-green[bot] merged 13 commits intomasterfrom
Conversation
|
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
1 similar comment
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
There was a problem hiding this comment.
After careful consideration:
-
When r.Request is nil, we pipe error message to errc like @tbpg suggested!
-
When protoStruct contains non-parseable but VALID JSON, we don't log to user at all because i) they will already know a property didn't parse correctly (see a nil value) ii) It's not a user error and there's nothing the user can do to solve this issue. So we don't log per client library convention to be less verbose.
"libraries shouldn't log" :)
|
@codyoss ready for your review on previous change requested, thanks! |
fixes: #1862
Changes: